Merge branch 'topic/kp_20186' into 'master'

Add detector for KP 20186

Closes #583

See merge request eng/libadalang/langkit-query-language!581

Author: HugoGGuerrier

lkql_checker/share/lkql/kp/kp_20186.lkql

@@ -0,0 +1,10 @@
+@check(help="possible occurrence of KP 20186",
+       message="possible occurrence of KP 20186")
+fun kp_20186(node) =
+    |" Flag private type declarations which full type is a scalar type with a
+    |" size representation clause.
+    node is BaseTypeDecl(p_is_private(): true) when
+        node.p_full_view() is t@BaseTypeDecl(
+            p_is_scalar_type(): true,
+            p_has_aspect("size"): true
+        )

testsuite/tests/checks/KP-20186/main.ads

@@ -0,0 +1,15 @@
+package Main is
+   type Pub_Range is range 1 .. 2 with Size => 8;  --  NOFLAG
+   type Priv_Range is private;                     --  FLAG
+   subtype Priv_Range_Sub is Priv_Range;           --  NOFLAG
+   type Priv_Float_Range is private;               --  FLAG
+   type Priv_Enum is private;                      --  FLAG
+   type Priv_Range_No_Size is private;             --  NOFLAG
+   type Priv_Arr is private;                       --  NOFLAG
+private
+   type Priv_Range is range 1 .. 2 with Size => 8;
+   type Priv_Float_Range is digits 8 with Size => 64;
+   type Priv_Enum is (A, B, C) with Size => 8;
+   type Priv_Range_No_Size is range 1 .. 2;
+   type Priv_Arr is array (1 .. 2) of Integer with Size => 64;
+end Main;

testsuite/tests/checks/KP-20186/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/KP-20186/test.out

@@ -0,0 +1,12 @@
+main.ads:3:9: rule violation: possible occurrence of KP 20186
+3 |    type Priv_Range is private;                     --  FLAG
+  |         ^^^^^^^^^^
+
+main.ads:5:9: rule violation: possible occurrence of KP 20186
+5 |    type Priv_Float_Range is private;               --  FLAG
+  |         ^^^^^^^^^^^^^^^^
+
+main.ads:6:9: rule violation: possible occurrence of KP 20186
+6 |    type Priv_Enum is private;                      --  FLAG
+  |         ^^^^^^^^^
+

testsuite/tests/checks/KP-20186/test.yaml

@@ -0,0 +1,3 @@
+driver: checker
+rule_name: kp_20186
+project: prj.gpr

testsuite/tests/gnatcheck/xml_help/test.out

@@ -99,6 +99,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_20023" label="possible occurrence of KP 20023"/>
       <check switch="+Rkp_20089" label="possible occurrence of KP 20089"/>
       <check switch="+Rkp_20113" label="possible occurrence of KP 20113"/>
+      <check switch="+Rkp_20186" label="possible occurrence of KP 20186"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>
@@ -623,6 +624,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_20023" label="possible occurrence of KP 20023"/>
       <check switch="+Rkp_20089" label="possible occurrence of KP 20089"/>
       <check switch="+Rkp_20113" label="possible occurrence of KP 20113"/>
+      <check switch="+Rkp_20186" label="possible occurrence of KP 20186"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>