Merge branch 'topic/gnatcheck/cleanup_switches' into 'master'

Migrate more GNATcheck switches to Opt_Parse

Closes #391 and #540

See merge request eng/libadalang/langkit-query-language!541

Author: HugoGGuerrier

lkql_checker/doc/gnatcheck_rm/using_gnatcheck.rst

@@ -22,7 +22,7 @@ The following switches control the general ``gnatcheck`` behavior
   .. index:: --help
 
 
-``--help``
+``-h, --help``
   Display usage, then exit disregarding all other options.
 
   .. index:: -P file
@@ -85,6 +85,11 @@ The following switches control the general ``gnatcheck`` behavior
 
   .. index:: --ignore-project-switches
 
+``-vP level``
+  Set the verbosity level when parsing a project file. The level is expressed
+  as a natural number between ``0`` and ``2``; ``0`` being the less verbose and
+  ``2`` being very verbose (default is ``0``).
+
 ``--ignore-project-switches``
   Ignore gnatcheck switches specified in the package ``Check`` of the main
   project file.
@@ -100,10 +105,10 @@ The following switches control the general ``gnatcheck`` behavior
 ``--RTS=rts-path``
   Specifies the default location of the runtime library.
 
-  .. index:: -h
+  .. index:: --list-rules
 
-``-h``
-  List all the rules checked by the given ``gnatcheck`` version.
+``--list-rules``
+  List all available GNATcheck rules and exit.
 
   .. index:: -j
 
@@ -391,10 +396,13 @@ GNATcheck:
     ``Switches`` attribute:
 
     * ``--version``
-    * ``--help``
+    * ``-h, --help``
+    * ``--list-rules``
     * ``-P``
     * ``-U``
     * ``-Xname=value``
+    * ``--no-subprojects``
+    * ``-vP``
     * ``-eL``
     * ``-r, --rule [rule_name]`` (use ``Rules`` attribute instead)
     * ``--rule-file=filename`` (use ``Rule_File`` attribute instead)
@@ -691,8 +699,8 @@ can provide as many rule options as you want after the ``-rules`` switch.
   Create and enable an instance of the specified rule with the specified
   parameter(s), if any.
   `rule_id` must be the identifier of one of the currently implemented
-  rules (use ``-h`` for the list of implemented rules). Rule identifiers
-  are not case-sensitive.
+  rules (use ``--list-rules`` for the list of implemented rules). Rule
+  identifiers are not case-sensitive.
 
   Each `param` item must be a non-empty string representing a valid parameter
   for the specified rule. If the part of the rule option that follows the
@@ -1150,11 +1158,11 @@ source locations will be generated on standard error, as well as in a file
 called :file:`gnatkp.out`.
 
 You can display the list of detectors without running them by specifying
-additionally the ``-h`` switch, e.g.:
+additionally the ``--list-rules`` switch, e.g.:
 
 .. code-block:: none
 
-  gnatkp --kp-version=21.2 -h --target=<my_target> --RTS=<my_runtime>
+  gnatkp --kp-version=21.2 --list-rules --target=<my_target> --RTS=<my_runtime>
 
 You can also combine the ``--kp-version`` switch with the ``--target`` switch
 to filter out detectors not relevant for your target, e.g:
@@ -1177,10 +1185,10 @@ using the switch ``-r``:
   gnatkp -Pproject --target=<my_target> --RTS=<my_runtime> -r kp_xxxx_xxx [-r kp_xxxx_xxx]
 
 where ``kp_xxxx_xxx`` is the name of a relevant known-problem to detect. You
-can get the list of available detectors via the command ``gnatkp -h``. When
-combined with the ``--kp-version`` and possibly ``--target`` switches,
-``gnatkp -h`` will only list the detectors relevant to the version
-(and target) specified.
+can get the list of available detectors via the command
+``gnatkp --list-rules``. When combined with the ``--kp-version`` and possibly
+``--target`` switches, ``gnatkp --list-rules`` will only list the detectors
+relevant to the version (and target) specified.
 
 .. attention::
 

lkql_checker/doc/gnatcheck_rm/writing_your_own_rules.rst

@@ -131,8 +131,8 @@ Rules can take different optional arguments:
 * ``message``: The custom message that is to be shown for a given rule on the
   command line. Defaults to the name of the rule if not specified.
 
-* ``help``: The help message that is to be shown via ``gnatcheck -h``. Defaults to
-  message if not specified.
+* ``help``: The help message that is to be shown via
+  ``gnatcheck --list-rules``. Defaults to message if not specified.
 
 * ``follow_generic_instantiations``: Whether to follow generic instantiations
   during the traversal of given Ada units. If ``true``, generic instantiations
@@ -147,8 +147,8 @@ Rules can take different optional arguments:
   * MEDIUM
   * MAJOR
 
-  Used by ``gnatcheck -h`` and by the SonarQube integration to compute technical debt.
-  Defaults to `MEDIUM`.
+  Used by ``gnatcheck --list-rules`` and by the SonarQube integration to
+  compute technical debt. Defaults to `MEDIUM`.
 
 Here is an example rule:
 
@@ -537,4 +537,3 @@ which gives us this complete rule:
         when not [t for t in types() if t == node]
          and not [t for t in instantiations() if t == node]
          and not [t for t in arithmetic_ops() if t == node]
-

lkql_checker/src/checker_app.ads

@@ -1885,7 +1885,7 @@ package body Gnatcheck.Compiler is
       Num_Args := @ + 1;
       Args (Num_Args) := new String'(LKQL_RF_Name);
 
-      if Verbose_Mode then
+      if Arg.Verbose.Get then
          Num_Args := @ + 1;
          Args (Num_Args) := new String'("--verbose");
       end if;
@@ -1963,7 +1963,7 @@ package body Gnatcheck.Compiler is
       --  If files are specified explicitly, only compile these files
 
       if (Argument_File_Specified and then not Arg.Transitive_Closure.Get)
-        or else File_List_Specified
+        or else Arg.Source_Files_Specified
       then
          Num_Args := @ + 1;
          Args (Num_Args) := new String'("-u");