Merge branch 'topic/449' into 'master'

Fix metrics.lkql's statement_complexity regarding SelectStmt

Closes #449

See merge request eng/libadalang/langkit-query-language!412

Author: thvnx

lkql_checker/share/lkql/metrics.lkql

@@ -39,7 +39,7 @@ fun statement_complexity(body, exempt_case=false) =
         | e@ExitStmt(f_cond_expr: not null) => 1
         | s@SelectStmt(
             f_guards: guards,
-            f_else_stmts: elses_stmts,
+            f_else_part: elses_stmts,
             f_then_abort_part: then_abort_part
         ) => guards.children_count
              + (if elses_stmts.children_count == 0 then 0 else 1)

testsuite/tests/checks/metrics_cyclomatic/proc.adb

@@ -36,11 +36,33 @@ procedure Proc (I : in out Integer; S : String) is   --  FLAG Complexity 7
             when 2 => null;
             when 3 => null;
             when 4 => null;
-            when others => I := if I > 0 then 1 elsif False then 2 else 3;
+            when others => I := (if I > 0 then 1 elsif False then 2 else 3);
          end case;
       end E1;
    end Prot;
 
+   task U is
+      entry E1;
+      entry E2;
+      entry E3;
+      entry E4;
+   end U;
+
+   task body U is  --  FLAG Complexity 6
+   begin
+      select
+         accept E1;
+      or
+         accept E2;
+      or
+         accept E3;
+      or
+         accept E4;
+      or
+         terminate;
+      end select;
+   end U;
+
 begin
    if I in 1 .. 10 then
       for J in S'Range loop

testsuite/tests/checks/metrics_cyclomatic/test.out

@@ -2,9 +2,9 @@ proc.adb:1:1: rule violation: cyclomatic complexity is too high: 7
 1  |  procedure Proc (I : in out Integer; S : String) is   --  FLAG Complexity 7
    | _^
    ||
-   || ~~~ 58 other lines ~~~
+   || ~~~ 80 other lines ~~~
    ||
-60 || end Proc;
+82 || end Proc;
    ||_________^
 
 proc.adb:8:4: rule violation: cyclomatic complexity is too high: 6
@@ -34,3 +34,12 @@ proc.adb:32:7: rule violation: cyclomatic complexity is too high: 7
 41 ||       end E1;
    ||_____________^
 
+proc.adb:51:4: rule violation: cyclomatic complexity is too high: 6
+51 |     task body U is  --  FLAG Complexity 6
+   | ____^
+   ||
+   || ~~~ 12 other lines ~~~
+   ||
+64 ||    end U;
+   ||_________^
+