Merge branch 'topic/493' into 'master'

Add detector for KP-19915

Closes #493

See merge request eng/libadalang/langkit-query-language!494

Author: thvnx

lkql_checker/share/lkql/kp/KP-19915.lkql

@@ -0,0 +1,7 @@
+@check(help="occurrence of KP 19915",
+       message="occurrence of KP 19915")
+fun kp_19915(node) =
+    |" Search for `'Class'Max_Size_In_Storage_Elements`.
+    node is AttributeRef(f_prefix: prefix@AttributeRef)
+    when node.f_attribute.p_name_is("Max_Size_In_Storage_Elements")
+    and prefix.f_attribute.p_name_is("Class")

lkql_checker/share/lkql/kp/kp.json

@@ -26,6 +26,7 @@
         "kp_19749": "24.*,25.*",
         "kp_19753": "21.*,22.*,23.*,24.1,24.2,25.1",
         "kp_19824": "25.*",
+        "kp_19915": "25.1",
         "kp_ob03_009": "19.*",
         "kp_p226_024": "7.1.*,7.2.*,7.3.*,7.4.1,7.4.2,7.4.3",
         "kp_q309_014": "7.1.*,7.2.*,7.3.*,7.4.*,17.*",

testsuite/tests/checks/KP-19915/main.adb

@@ -0,0 +1,11 @@
+procedure Main is
+   type T is tagged null record;
+   type U is new T with record I: Integer; end record;
+
+   A : Long_Integer := T'Max_Size_In_Storage_Elements;  --  NOFLAG
+   B : T'Class := U'(I => 1);  --  NOFLAG
+
+   Size : Long_Integer := T'Class'Max_Size_In_Storage_Elements;  --  FLAG
+begin
+   null;
+end;

testsuite/tests/checks/KP-19915/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/KP-19915/test.out

@@ -0,0 +1,4 @@
+main.adb:8:27: rule violation: occurrence of KP 19915
+8 |    Size : Long_Integer := T'Class'Max_Size_In_Storage_Elements;  --  FLAG
+  |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+

testsuite/tests/checks/KP-19915/test.yaml

@@ -0,0 +1,3 @@
+driver: checker
+rule_name: kp_19915
+project: prj.gpr

testsuite/tests/gnatcheck/xml_help/test.out

@@ -92,6 +92,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_19749" label="possible occurrence of KP 19749"/>
       <check switch="+Rkp_19753" label="possible occurrence of KP 19753"/>
       <check switch="+Rkp_19824" label="possible occurrence of KP 19824"/>
+      <check switch="+Rkp_19915" label="occurrence of KP 19915"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>
@@ -609,6 +610,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_19749" label="possible occurrence of KP 19749"/>
       <check switch="+Rkp_19753" label="possible occurrence of KP 19753"/>
       <check switch="+Rkp_19824" label="possible occurrence of KP 19824"/>
+      <check switch="+Rkp_19915" label="occurrence of KP 19915"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>