Merge branch 'topic/gnatcheck/format_ada_code' into 'master'

Introduce GNATformat as Ada source formatter

Closes #424

See merge request eng/libadalang/langkit-query-language!414

Author: HugoGGuerrier

Makefile

@@ -41,9 +41,11 @@ impacts:
 	PYTHONPATH=$(IMPACTDB_DIR) ./utils/impact-db_impacts_gen.py $(IMPACTDB_DIR)
 
 format:
+	gnatformat -P lkql_checker/gnatcheck.gpr --no-subprojects
 	$(MAVEN) -f lkql_jit spotless:apply
 
 gnatcheck: lkql
+	gnatformat -P lkql_checker/gnatcheck.gpr --no-subprojects --check
 	gprbuild -P lkql_checker/gnatcheck.gpr -p $(GPR_ARGS) -XBUILD_MODE=$(BUILD_MODE)
 
 build/bin/liblkqllang_parse: lkql/lkql.lkt
@@ -74,6 +76,7 @@ automated:
 	rm -rf "$(PREFIX)"
 	mkdir -p "$(PREFIX)/share" "$(PREFIX)/share/examples" "$(PREFIX)/lib"
 	$(LKM) make -c lkql/langkit.yaml $(MANAGE_ARGS) $(ADDITIONAL_MANAGE_ARGS)
+	gnatformat -P lkql_checker/gnatcheck.gpr --check --no-subprojects
 	$(GPRBUILD) -Plkql_checker/gnatcheck.gpr -largs -s
 	$(GPRINSTALL) --mode=usage -Plkql_checker/gnatcheck.gpr
 	$(GPRINSTALL) --mode=usage -P$(LKQL_DIR)/mains.gpr
@@ -102,4 +105,3 @@ automated-cov:
 	mkdir -p "$(PREFIX)/lib/lkql_checker"
 	cp -p "$(BUILD_DIR)/lkql_checker/obj/$(BUILD_MODE)/"*.sid \
 	  "$(PREFIX)/lib/lkql_checker"
-

lkql_checker/gnatcheck.gpr

@@ -3,7 +3,6 @@ with "liblkqllang";
 with "gpr2";
 
 project GNATcheck is
-
    type Build_Mode_Type is ("dev", "prod");
    Build_Mode : Build_Mode_Type := external
      ("BUILD_MODE", external ("LKQL_CHECKER_BUILD_MODE", "dev"));
@@ -39,4 +38,9 @@ project GNATcheck is
       for Default_Switches ("Ada") use Switches;
    end Compiler;
 
+   package Format is
+      for End_Of_Line ("Ada") use "lf";
+      for Charset ("Ada") use "utf-8";
+      for Width ("Ada") use "79";
+   end Format;
 end GNATcheck;

lkql_checker/src/checker_app.ads

@@ -11,18 +11,19 @@ with Libadalang.Analysis; use Libadalang.Analysis;
 with Rules_Factory; use Rules_Factory;
 
 --  TODO: Factor into another package, check what is dead. See #190
+
 package Checker_App is
 
    package LK renames Langkit_Support.Generic_API.Analysis;
    package LKI renames Langkit_Support.Generic_API.Introspection;
 
-   type Rules_By_Kind_Array
-   is array (LKI.Any_Type_Index range <>) of Rule_Vector;
+   type Rules_By_Kind_Array is
+     array (LKI.Any_Type_Index range <>) of Rule_Vector;
 
    type Rules_By_Kind is access all Rules_By_Kind_Array;
 
    type Lkql_Context is record
-      Analysis_Ctx : Analysis_Context;
+      Analysis_Ctx          : Analysis_Context;
       LKQL_Analysis_Context : L.Analysis_Context;
 
       Cached_Rules : Rules_By_Kind := null;