Fix Kp detector TA30-032

thvnx · thvnx · commit e2dc7ed48b85 · 2025-02-26T15:39:19.000Z
This change improves subtypes support.
diff --git a/lkql_checker/share/lkql/kp/KP-TA30-032.lkql b/lkql_checker/share/lkql/kp/KP-TA30-032.lkql
@@ -4,7 +4,7 @@
 import stdlib
 
 fun range_length(t) =
-    match t.f_type_def.f_indices.f_types[1]
+    match t.p_base_subtype().f_type_def.f_indices.f_types[1]
     | u@UnconstrainedArrayIndex => stdlib.number_of_values(
         u.f_subtype_name.p_referenced_decl()
       )
diff --git a/testsuite/tests/checks/KP-TA30-032/simple.ads b/testsuite/tests/checks/KP-TA30-032/simple.ads
@@ -12,4 +12,7 @@ package Simple is
    type Element_Array is array (Index_Range range <>) of Element;
    Null_Element_Array : Element_Array (1 .. 0);  --  FLAG
 
+   subtype Sub_Element_Array is Element_Array;
+   Null_Sub_Element_Array : Sub_Element_Array (1 .. 0);  --  FLAG
+
 end Simple;
diff --git a/testsuite/tests/checks/KP-TA30-032/test.out b/testsuite/tests/checks/KP-TA30-032/test.out
@@ -6,3 +6,7 @@ simple.ads:13:4: rule violation: possible occurrence of KP TA30-032
 13 |    Null_Element_Array : Element_Array (1 .. 0);  --  FLAG
    |    ^^^^^^^^^^^^^^^^^^
 
+simple.ads:16:4: rule violation: possible occurrence of KP TA30-032
+16 |    Null_Sub_Element_Array : Sub_Element_Array (1 .. 0);  --  FLAG
+   |    ^^^^^^^^^^^^^^^^^^^^^^
+

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`import stdlib`
`5`	`5`
`6`	`6`	`fun range_length(t) =`
`7`		`- match t.f_type_def.f_indices.f_types[1]`
	`7`	`+ match t.p_base_subtype().f_type_def.f_indices.f_types[1]`
`8`	`8`	`\| u@UnconstrainedArrayIndex => stdlib.number_of_values(`
`9`	`9`	`u.f_subtype_name.p_referenced_decl()`
`10`	`10`	`)`