Merge branch 'topic/gnatcheck/split_rule_interfaces' into 'master'

Avoid emitting hint messages when only using the new rule options API

Closes #455

See merge request eng/libadalang/langkit-query-language!461

Author: HugoGGuerrier

lkql_checker/src/gnatcheck-diagnoses.adb

@@ -1292,13 +1292,13 @@ package body Gnatcheck.Diagnoses is
            ("<coding-standard from-file=""", Indent_Level => 1);
       end if;
 
-      if not Individual_Rules_Set and then Rule_File_Name /= null then
+      if not Individual_Rules_Set and then Legacy_Rule_File_Name /= null then
          if Text_Report_ON then
-            Report (Rule_File_Name.all);
+            Report (Legacy_Rule_File_Name.all);
          end if;
 
          if XML_Report_ON then
-            XML_Report (Rule_File_Name.all & """>");
+            XML_Report (Legacy_Rule_File_Name.all & """>");
          end if;
       else
          --  Creating the list of active rules

lkql_checker/src/gnatcheck-options.ads

@@ -209,14 +209,14 @@ package Gnatcheck.Options is
    --  section of the report file. If this option is not set, this section is
    --  not created in the report file.
 
-   Individual_Rules_Set        : Boolean := False;
-   More_Then_One_Rule_File_Set : Boolean := False;
+   Individual_Rules_Set               : Boolean := False;
+   More_Than_One_Legacy_Rule_File_Set : Boolean := False;
    --  Flags used to detect if all the rules specified for a given gnatcheck
    --  call, should be set when parsing rule options
 
-   Rule_File_Name : GNAT.OS_Lib.String_Access;
-   --  If More_Then_One_Rule_File_Set is OFF and if a rule file has been
-   --  processed, keeps the name of this file, otherwise is null.
+   Legacy_Rule_File_Name : GNAT.OS_Lib.String_Access;
+   --  If ``More_Than_One_Legacy_Rule_File_Set`` is OFF and if a rule file has
+   --  been processed, keeps the name of this file, otherwise is null.
 
    LKQL_Rule_File_Name : Unbounded_String := Null_Unbounded_String;
    --  Name of the LKQL file to process as a rule file. We assume that the

lkql_checker/src/gnatcheck-projects.adb

@@ -99,7 +99,7 @@ package body Gnatcheck.Projects is
      (Self : Gnatcheck_Reporter) return GPR2.Reporter.Verbosity_Level;
 
    Gpr2_Reporter : Gnatcheck_Reporter;
-   --  Make libgpt2 report messages using the proper gnatcheck.Output API
+   --  Make libgpr2 report messages using the proper ``Gnatcheck.Output`` API.
 
    function Report_Missing_File (Log : String) return Boolean
    is (Index (Log, "source file") /= 0 and then Index (Log, "not found") /= 0);
@@ -1056,7 +1056,7 @@ package body Gnatcheck.Projects is
    -- Process_Rule_Options --
    --------------------------
 
-   type Option_Kind is (File, Option);
+   type Option_Kind is (File, Legacy_Option, Single_Rule_Name);
 
    type Option_Record is record
       Kind  : Option_Kind;
@@ -1080,43 +1080,53 @@ package body Gnatcheck.Projects is
       for O of Rule_Options loop
          case O.Kind is
             when File =>
-               Process_Rule_File (To_String (O.Value));
+               Process_Legacy_Rule_File (To_String (O.Value));
 
-            when Option =>
-               Process_Rule_Option (To_String (O.Value), Defined_At => "");
+            when Legacy_Option =>
+               Process_Legacy_Rule_Option
+                 (To_String (O.Value), Defined_At => "");
+
+            when Single_Rule_Name =>
+               Process_Single_Rule_Name (To_String (O.Value));
          end case;
       end loop;
       Process_Compiler_Instances;
    end Process_Rule_Options;
 
-   ---------------------
-   -- Add_Rule_Option --
-   ---------------------
+   ----------------------------
+   -- Add_Legacy_Rule_Option --
+   ----------------------------
 
-   procedure Add_Rule_Option (Opt : String; Prepend : Boolean := False) is
+   procedure Add_Legacy_Rule_Option (Opt : String; Prepend : Boolean := False)
+   is
       use Ada.Strings.Unbounded;
 
       Opt_Rec : constant Option_Record :=
-        (Option, To_Unbounded_String (Trim (Opt, Both)));
+        (Legacy_Option, To_Unbounded_String (Trim (Opt, Both)));
    begin
       if Prepend then
          Rule_Options.Prepend (Opt_Rec);
       else
          Rule_Options.Append (Opt_Rec);
       end if;
-   end Add_Rule_Option;
+   end Add_Legacy_Rule_Option;
 
    ----------------------
    -- Add_Rule_By_Name --
    ----------------------
 
    procedure Add_Rule_By_Name (Rule_Name : String; Prepend : Boolean := False)
    is
-      Lower_Rule : constant String := To_Lower (Rule_Name);
-      Prefix     : constant String :=
-        (if Lower_Rule = "all" then "+" else "+R");
+      use Ada.Strings.Unbounded;
+
+      Opt_Rec : constant Option_Record :=
+        (Single_Rule_Name, To_Unbounded_String (Trim (Rule_Name, Both)));
    begin
-      Add_Rule_Option (Prefix & Lower_Rule, Prepend => Prepend);
+      if Prepend then
+         Rule_Options.Prepend (Opt_Rec);
+      else
+         Rule_Options.Append (Opt_Rec);
+      end if;
    end Add_Rule_By_Name;
 
    ------------------------
@@ -1225,16 +1235,16 @@ package body Gnatcheck.Projects is
                     (Option_Record'
                        (File,
                         To_Unbounded_String (Parameter (Parser => Parser))));
-                  if not More_Then_One_Rule_File_Set then
-                     Rule_File_Name :=
+                  if not More_Than_One_Legacy_Rule_File_Set then
+                     Legacy_Rule_File_Name :=
                        new String'(Parameter (Parser => Parser));
-                     More_Then_One_Rule_File_Set := True;
+                     More_Than_One_Legacy_Rule_File_Set := True;
                   else
-                     Free (Rule_File_Name);
+                     Free (Legacy_Rule_File_Name);
                   end if;
 
                when others =>
-                  Add_Rule_Option (Full_Switch (Parser => Parser));
+                  Add_Legacy_Rule_Option (Full_Switch (Parser => Parser));
                   Individual_Rules_Set := True;
             end case;
             if not Rules_Depreciation_Emitted then

lkql_checker/src/gnatcheck-projects.ads

@@ -240,15 +240,15 @@ package Gnatcheck.Projects is
    procedure Process_Rule_Options;
    --  Process all the rule options found as part of scanning arguments
 
-   procedure Add_Rule_Option (Opt : String; Prepend : Boolean := False);
+   procedure Add_Legacy_Rule_Option (Opt : String; Prepend : Boolean := False);
    --  Add the given ``Opt`` to the list of rule options processed by
    --  ``Process_Rule_Options`` as a command-line rule option (e.g. +R...).
    --  If ``Prepend`` is set to True, add the rule option at the start of
    --  the processing list.
 
    procedure Add_Rule_By_Name (Rule_Name : String; Prepend : Boolean := False);
-   --  Use ``Add_Rule_Option`` to forge a new rule option enabling the given
-   --  rule without any parameter.
+   --  Use ``Add_Legacy_Rule_Option`` to forge a new rule option enabling the
+   --  given rule without any parameter.
 
    procedure Set_LKQL_Rule_File (File : String; Project_Relative : Boolean);
    --  Set the given ``File`` as the LKQL rule file to process during the