langkit.dsl_unparse: correctly unparse external properties

TN: RA22-015

Author: pmderodat

langkit/dsl_unparse.py

@@ -1256,7 +1256,13 @@ def emit_prop(prop, walker):
     if prop_for_walker.is_public:
         quals += "@export "
 
-    if not prop.constructed_expr:
+    if prop.external:
+        quals += "@external "
+        if prop.uses_entity_info:
+            quals += "@uses_entity_info "
+        if prop.uses_envs:
+            quals += "@uses_envs "
+    elif not prop.constructed_expr:
         quals += ("@not_implemented "
                   if prop.abstract_runtime_check
                   else "@abstract ")

testsuite/tests/ada_api/properties_introspection/expected_concrete_syntax.lkt

@@ -56,7 +56,7 @@ class Addition : Expr {
 
 class Number : Expr implements TokenNode {
 
-    @abstract fun eval(): Int
+    @external fun eval(): Int
 
     @export fun id_dflt_bool(id: Bool = true): Bool = id
 

testsuite/tests/lexical_envs/ple_after_reparse/expected_concrete_syntax.lkt

@@ -23,7 +23,7 @@ class Dep : FooNode {
 
     @export @abstract fun suffix_symbol(): Symbol
 
-    @abstract fun referenced_unit_or_error(or_error: Bool): AnalysisUnit[FooNode]
+    @external fun referenced_unit_or_error(or_error: Bool): AnalysisUnit[FooNode]
 
     @export fun referenced_unit(): AnalysisUnit[FooNode] =
     node.referenced_unit_or_error(false)

testsuite/tests/misc/event_handler/expected_concrete_syntax.lkt

@@ -7,7 +7,7 @@ grammar foo_grammar {
 
 @abstract class FooNode implements Node[FooNode] {
 
-    @export @abstract fun get_unit(name: Symbol): AnalysisUnit[FooNode]
+    @export @external fun get_unit(name: Symbol): AnalysisUnit[FooNode]
 }
 
 class Example : FooNode implements TokenNode {

testsuite/tests/properties/analysis_unit/expected_concrete_syntax.lkt

@@ -19,12 +19,12 @@ grammar foo_grammar {
 
 class Literal : Expression implements TokenNode {
 
-    @abstract fun result(): Int
+    @external fun result(): Int
 }
 
 class Name : Expression implements TokenNode {
 
-    @abstract fun designated_unit(): AnalysisUnit[FooNode]
+    @external @uses_envs fun designated_unit(): AnalysisUnit[FooNode]
 
     fun result(): Int = node.designated_unit().root.as[Expression].result()
 }

testsuite/tests/properties/big_integer/expected_concrete_syntax.lkt

@@ -54,7 +54,7 @@ class LessThan : Expr {
 
 class Literal : Expr implements TokenNode {
 
-    @abstract fun evaluate(): BigInt
+    @external fun evaluate(): BigInt
 }
 
 class Minus : Expr {

testsuite/tests/properties/external/expected_concrete_syntax.lkt

@@ -16,7 +16,7 @@ grammar foo_grammar {
 
 class Literal : Expression implements TokenNode {
 
-    @abstract fun result(): Int
+    @external fun result(): Int
 }
 
 class Plus : Expression {

testsuite/tests/properties/invalidation_during_mmz/expected_concrete_syntax.lkt

@@ -10,7 +10,7 @@ grammar foo_grammar {
 
 class Example : FooNode {
 
-    @abstract fun fetch_example_unit(): AnalysisUnit[FooNode]
+    @external fun fetch_example_unit(): AnalysisUnit[FooNode]
 
     @memoized fun internal_mmz_prop(i: Int): Int =
     if (i = 0) then (raise PropertyError()) else i

testsuite/tests/properties/memoized_unit_loading/expected_concrete_syntax.lkt

@@ -10,9 +10,9 @@ grammar foo_grammar {
 
 class Example : FooNode {
 
-    @abstract fun ext_fetch_example_unit(): AnalysisUnit[FooNode]
+    @external fun ext_fetch_example_unit(): AnalysisUnit[FooNode]
 
-    @abstract fun ext_unit_count(): Int
+    @external fun ext_unit_count(): Int
 
     @memoized fun fetch_example_unit(): AnalysisUnit[FooNode] =
     node.ext_fetch_example_unit()