Fix Sleeping-in-atomic inside p_sysctl_msr_validate

Adam-pi3 · Adam-pi3 · commit 062639c97514 · 2025-12-11T08:46:49.000Z
Fixes lkrg-org#449
diff --git a/src/modules/comm_channel/p_comm_channel.c b/src/modules/comm_channel/p_comm_channel.c
@@ -798,9 +798,9 @@ static int p_sysctl_msr_validate(P_STRUCT_CTL_TABLE *p_table, int p_write,
    int p_cpu;
    unsigned int p_tmp;
 
+   p_lkrg_open_rw();
    write_lock(&p_config_lock);
    p_tmp = P_CTRL(p_msr_validate);
-   p_lkrg_open_rw();
    if ( (p_ret = proc_dointvec_minmax(p_table, p_write, p_buffer, p_len, p_pos)) == 0 && p_write) {
       if (P_CTRL(p_msr_validate) && !p_tmp) {
          P_CTRL(p_profile_validate) = 9;
@@ -818,8 +818,8 @@ static int p_sysctl_msr_validate(P_STRUCT_CTL_TABLE *p_table, int p_write,
          p_db.p_CPU_metadata_hashes = hash_from_CPU_data(p_db.p_CPU_metadata_array);
       }
    }
-   p_lkrg_close_rw();
    write_unlock(&p_config_lock);
+   p_lkrg_close_rw();
 
    return p_ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -798,9 +798,9 @@ static int p_sysctl_msr_validate(P_STRUCT_CTL_TABLE *p_table, int p_write,`
`798`	`798`	`int p_cpu;`
`799`	`799`	`unsigned int p_tmp;`
`800`	`800`
	`801`	`+ p_lkrg_open_rw();`
`801`	`802`	`write_lock(&p_config_lock);`
`802`	`803`	`p_tmp = P_CTRL(p_msr_validate);`
`803`		`- p_lkrg_open_rw();`
`804`	`804`	`if ( (p_ret = proc_dointvec_minmax(p_table, p_write, p_buffer, p_len, p_pos)) == 0 && p_write) {`
`805`	`805`	`if (P_CTRL(p_msr_validate) && !p_tmp) {`
`806`	`806`	`P_CTRL(p_profile_validate) = 9;`
`@@ -818,8 +818,8 @@ static int p_sysctl_msr_validate(P_STRUCT_CTL_TABLE *p_table, int p_write,`
`818`	`818`	`p_db.p_CPU_metadata_hashes = hash_from_CPU_data(p_db.p_CPU_metadata_array);`
`819`	`819`	`}`
`820`	`820`	`}`
`821`		`- p_lkrg_close_rw();`
`822`	`821`	`write_unlock(&p_config_lock);`
	`822`	`+ p_lkrg_close_rw();`
`823`	`823`
`824`	`824`	`return p_ret;`
`825`	`825`	`}`