Skip to content

Commit 043b3db

Browse files
authored
Empty labels not being hidden (#67)
* style fixes * Change files
1 parent d3d911a commit 043b3db

File tree

10 files changed

+25
-9
lines changed

10 files changed

+25
-9
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "hide unused labels",
4+
"packageName": "@adaptive-web/adaptive-web-components",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/adaptive-web-components/src/components/checkbox/checkbox.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export const templateStyles: ElementStyles = css`
4848
cursor: pointer;
4949
}
5050
51-
.label__hidden {
51+
.label.label__hidden {
5252
display: none;
5353
visibility: hidden;
5454
}

packages/adaptive-web-components/src/components/number-field/number-field.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const templateStyles: ElementStyles = css`
3030
cursor: pointer;
3131
}
3232
33-
.label__hidden {
33+
.label.label__hidden {
3434
display: none;
3535
visibility: hidden;
3636
}

packages/adaptive-web-components/src/components/picker-list/picker-list.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export const templateStyles: ElementStyles = css`
2929
3030
::slotted([role="combobox"]) {
3131
box-sizing: border-box;
32-
min-width: 250px;
3332
width: auto;
3433
border: none;
3534
outline: none;

packages/adaptive-web-components/src/components/picker/picker.styles.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { css, ElementStyles } from "@microsoft/fast-element";
2+
import { designUnit, elevationFlyout, layerCornerRadius, layerFillFixedPlus1, strokeWidth } from "@adaptive-web/adaptive-ui";
23

34
/**
45
* Basic layout styling associated with the anatomy of the template.
@@ -39,4 +40,13 @@ export const templateStyles: ElementStyles = css`
3940
/**
4041
* Visual styles including Adaptive UI tokens.
4142
*/
42-
export const aestheticStyles: ElementStyles = css``;
43+
export const aestheticStyles: ElementStyles = css`
44+
.loading-display,
45+
.no-options-display {
46+
border: calc(${strokeWidth} * 1px) solid transparent;
47+
border-radius: calc(${layerCornerRadius} * 1px);
48+
padding: calc(${designUnit} * 1px);
49+
background: ${layerFillFixedPlus1};
50+
box-shadow: ${elevationFlyout};
51+
}
52+
`;

packages/adaptive-web-components/src/components/radio/radio.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const templateStyles: ElementStyles = css`
5858
cursor: pointer;
5959
}
6060
61-
.label__hidden {
61+
.label.label__hidden {
6262
display: none;
6363
visibility: hidden;
6464
}

packages/adaptive-web-components/src/components/search/search.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const templateStyles: ElementStyles = css`
6363
opacity: 0;
6464
}
6565
66-
.label__hidden {
66+
.label.label__hidden {
6767
display: none;
6868
visibility: hidden;
6969
}

packages/adaptive-web-components/src/components/switch/switch.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const templateStyles: ElementStyles = css`
4141
cursor: pointer;
4242
}
4343
44-
.label__hidden {
44+
.label.label__hidden {
4545
display: none;
4646
visibility: hidden;
4747
}

packages/adaptive-web-components/src/components/text-area/text-area.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const templateStyles: ElementStyles = css`
2626
/* position: relative; */
2727
}
2828
29-
.label__hidden {
29+
.label.label__hidden {
3030
display: none;
3131
visibility: hidden;
3232
}

packages/adaptive-web-components/src/components/text-field/text-field.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export const templateStyles: ElementStyles = css`
3232
-webkit-appearance: none;
3333
}
3434
35-
.label__hidden {
35+
.label.label__hidden {
3636
display: none;
3737
visibility: hidden;
3838
}

0 commit comments

Comments
 (0)