Add optional add_sycl_to_target to cmake

Author: sbalint98

CMakeLists.txt

@@ -68,6 +68,7 @@ endif()
 option(ENABLE_CUBLAS_BACKEND "" OFF)
 option(ENABLE_CURAND_BACKEND "" OFF)
 option(ENABLE_NETLIB_BACKEND "" OFF)
+set(ONEMKL_SYCL_IMPLEMENTATION "dpc++" CACHE STRING "Specifiy the SYCL implementation against which oneMKL should be built")
 
 ## Domains
 set(DOMAINS_LIST "")
@@ -124,7 +125,19 @@ list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake")
 if(WIN32)
   add_library(ONEMKL::SYCL::SYCL INTERFACE IMPORTED)
 else()
-  find_package(Compiler REQUIRED)
+  # Find necessary packages
+  if (ONEMKL_SYCL_IMPLEMENTATION STREQUAL "hipSYCL")
+    message(STATUS "Looking for hipSYCL")
+    find_package(hipSYCL CONFIG REQUIRED)
+    set(USE_ADD_SYCL_TO_TARGET_INTEGRATION true)
+    add_library(ONEMKL::SYCL::SYCL INTERFACE IMPORTED)
+  elseif(ONEMKL_SYCL_IMPLEMENTATION STREQUAL "dpc++")
+    message(STATUS "Looking for dpc++")
+    set(USE_ADD_SYCL_TO_TARGET_INTEGRATION false)
+    find_package(Compiler REQUIRED)
+  else()
+    message(FATAL_ERROR "SYCL implementation ${ONEMKL_SYCL_IMPLEMENTATION} is not known")
+  endif()
 endif()
 
 # Add source directory and output to bin/

src/blas/CMakeLists.txt

@@ -31,12 +31,16 @@ target_include_directories(onemkl_blas
           ${CMAKE_BINARY_DIR}/bin
           $<TARGET_FILE_DIR:onemkl>
 )
-
 target_compile_options(onemkl_blas PRIVATE ${ONEMKL_BUILD_COPT})
 
 set_target_properties(onemkl_blas PROPERTIES
   POSITION_INDEPENDENT_CODE ON
 )
-target_link_libraries(onemkl_blas PUBLIC ONEMKL::SYCL::SYCL)
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET onemkl_blas SOURCES blas_loader.cpp)
+else()
+  target_link_libraries(onemkl_blas PUBLIC ONEMKL::SYCL::SYCL)
+endif()
+
 endif()
 

src/blas/backends/cublas/CMakeLists.txt

@@ -20,17 +20,16 @@
 set(LIB_NAME onemkl_blas_cublas)
 set(LIB_OBJ ${LIB_NAME}_obj)
 find_package(cuBLAS REQUIRED)
-
+set(SOURCES cublas_level1.cpp 
+                cublas_level2.cpp 
+                cublas_level3.cpp 
+                cublas_batch.cpp 
+                cublas_extensions.cpp 
+                cublas_scope_handle.cpp 
+                $<$<BOOL:${BUILD_SHARED_LIBS}>: mkl_blas_cublas_wrappers.cpp>)
 add_library(${LIB_NAME})
-add_library(${LIB_OBJ} OBJECT
-  cublas_level1.cpp
-  cublas_level2.cpp
-  cublas_level3.cpp
-  cublas_batch.cpp
-  cublas_extensions.cpp
-  cublas_scope_handle.cpp
-  $<$<BOOL:${BUILD_SHARED_LIBS}>: mkl_blas_cublas_wrappers.cpp>
-)
+add_library(${LIB_OBJ} OBJECT ${SOURCES})
+
 target_include_directories(${LIB_OBJ}
   PRIVATE ${PROJECT_SOURCE_DIR}/include
           ${PROJECT_SOURCE_DIR}/src
@@ -42,7 +41,9 @@ set_target_properties(${LIB_OBJ} PROPERTIES
   POSITION_INDEPENDENT_CODE ON)
 
 target_link_libraries(${LIB_NAME} PUBLIC ${LIB_OBJ})
-
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET ${LIB_OBJ} SOURCES ${SOURCES})
+endif()
 # Add major version to the library
 set_target_properties(${LIB_NAME} PROPERTIES
   SOVERSION ${PROJECT_VERSION_MAJOR}

src/blas/backends/mklcpu/CMakeLists.txt

@@ -21,13 +21,14 @@ set(LIB_NAME onemkl_blas_mklcpu)
 set(LIB_OBJ ${LIB_NAME}_obj)
 
 find_package(MKL REQUIRED)
-
-add_library(${LIB_NAME})
-add_library(${LIB_OBJ} OBJECT
-  fp16.hpp mklcpu_common.hpp
+set(SOURCES fp16.hpp mklcpu_common.hpp
   mklcpu_level1.cpp mklcpu_level2.cpp mklcpu_level3.cpp mklcpu_batch.cpp mklcpu_extensions.cpp
-  $<$<BOOL:${BUILD_SHARED_LIBS}>: mklcpu_wrappers.cpp>
-)
+  $<$<BOOL:${BUILD_SHARED_LIBS}>: mklcpu_wrappers.cpp>)
+add_library(${LIB_NAME})
+add_library(${LIB_OBJ} OBJECT ${SOURCES})
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET ${LIB_OBJ} ${SOURCES})
+endif()
 
 target_include_directories(${LIB_OBJ}
   PRIVATE ${PROJECT_SOURCE_DIR}/include

src/rng/CMakeLists.txt

@@ -37,5 +37,10 @@ target_compile_options(onemkl_rng PRIVATE ${ONEMKL_BUILD_COPT})
 set_target_properties(onemkl_rng PROPERTIES
   POSITION_INDEPENDENT_CODE ON
 )
-target_link_libraries(onemkl_rng PUBLIC ONEMKL::SYCL::SYCL)
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET onemkl_rng SOURCES rng_loader.cpp)
+else()
+  target_link_libraries(onemkl_rng PUBLIC ONEMKL::SYCL::SYCL)
+endif()
+
 endif()

src/rng/backends/curand/CMakeLists.txt

@@ -60,13 +60,14 @@ set(LIB_NAME onemkl_rng_curand)
 set(LIB_OBJ ${LIB_NAME}_obj)
 find_package(cuRAND REQUIRED)
 
-add_library(${LIB_NAME})
-add_library(${LIB_OBJ} OBJECT
-  philox4x32x10.cpp
+set(SOURCES philox4x32x10.cpp
   mrg32k3a.cpp
-  $<$<BOOL:${BUILD_SHARED_LIBS}>: mkl_rng_curand_wrappers.cpp>
+  $<$<BOOL:${BUILD_SHARED_LIBS}>: mkl_rng_curand_wrappers.cpp>)
 )
 
+add_library(${LIB_NAME})
+add_library(${LIB_OBJ} OBJECT ${SOURCES})
+
 target_include_directories(${LIB_OBJ}
   PRIVATE ${PROJECT_SOURCE_DIR}/include
           ${PROJECT_SOURCE_DIR}/src
@@ -81,7 +82,9 @@ set_target_properties(${LIB_OBJ} PROPERTIES
 )
 
 target_link_libraries(${LIB_NAME} PUBLIC ${LIB_OBJ})
-
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET ${LIB_OBJ} SOURCES ${SOURCES})
+endif()
 # Add major version to the library
 set_target_properties(${LIB_NAME} PROPERTIES
   SOVERSION ${PROJECT_VERSION_MAJOR}

src/rng/backends/mklcpu/CMakeLists.txt

@@ -22,14 +22,16 @@ set(LIB_OBJ ${LIB_NAME}_obj)
 
 find_package(MKL REQUIRED)
 
-add_library(${LIB_NAME})
-add_library(${LIB_OBJ} OBJECT
-  cpu_common.hpp
+set(SOURCES cpu_common.hpp
   philox4x32x10.cpp
   mrg32k3a.cpp
   $<$<BOOL:${BUILD_SHARED_LIBS}>: mkl_rng_cpu_wrappers.cpp>
 )
 
+add_library(${LIB_NAME})
+add_library(${LIB_OBJ} OBJECT ${SOURCES})
+
+
 target_include_directories(${LIB_OBJ}
   PRIVATE ${PROJECT_SOURCE_DIR}/include
           ${PROJECT_SOURCE_DIR}/src
@@ -38,7 +40,9 @@ target_include_directories(${LIB_OBJ}
 )
 
 target_compile_options(${LIB_OBJ} PRIVATE ${ONEMKL_BUILD_COPT} ${MKL_COPT})
-
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET ${LIB_OBJ} SOURCES ${SOURCES})
+endif()
 target_link_libraries(${LIB_OBJ} PUBLIC ONEMKL::SYCL::SYCL ${MKL_LINK_C})
 
 set_target_properties(${LIB_OBJ} PROPERTIES

tests/unit_tests/CMakeLists.txt

@@ -59,6 +59,9 @@ foreach(domain ${TARGET_DOMAINS})
   add_executable(test_main_${domain}_ct main_test.cpp)
   target_include_directories(test_main_${domain}_ct PUBLIC ${GTEST_INCLUDE_DIR})
   target_compile_options(test_main_${domain}_ct PRIVATE -fsycl)
+  if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+    add_sycl_to_target(TARGET test_main_${domain}_ct SOURCES t main_test.cpp)
+  endif()
 
   if(BUILD_SHARED_LIBS)
     add_executable(test_main_${domain}_rt main_test.cpp)
@@ -73,6 +76,9 @@ foreach(domain ${TARGET_DOMAINS})
       onemkl
       ${${domain}_TEST_LIST_RT}
     )
+    if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+      add_sycl_to_target(TARGET test_main_${domain}_rt SOURCES main_test.cpp)
+    endif()
   endif()
 
   if(ENABLE_MKLCPU_BACKEND)
@@ -109,7 +115,6 @@ foreach(domain ${TARGET_DOMAINS})
       ONEMKL::SYCL::SYCL
       ${${domain}_TEST_LIST_CT}
   )
-
   string(TOUPPER ${domain} DOMAIN_PREFIX)
 
   if(BUILD_SHARED_LIBS)
@@ -130,5 +135,8 @@ foreach(domain ${TARGET_DOMAINS})
     PROPERTIES TEST_PREFIX ${DOMAIN_PREFIX}/CT/
     DISCOVERY_TIMEOUT 30
   )
+  if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+    add_sycl_to_target(TARGET test_main_${domain}_rt)
+  endif()
 
 endforeach()

tests/unit_tests/blas/batch/CMakeLists.txt

@@ -32,6 +32,11 @@ if(BUILD_SHARED_LIBS)
       PUBLIC ${CBLAS_INCLUDE}
   )
   target_link_libraries(blas_batch_rt PUBLIC ONEMKL::SYCL::SYCL)
+  if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+    add_sycl_to_target(TARGET blas_batch_rt SOURCES ${BATCH_SOURCES})
+  else()
+    target_link_libraries(blas_batch_rt PUBLIC ONEMKL::SYCL::SYCL)
+  endif()
 endif()
 
 add_library(blas_batch_ct OBJECT ${BATCH_SOURCES})
@@ -45,3 +50,8 @@ target_include_directories(blas_batch_ct
     PUBLIC ${CBLAS_INCLUDE}
 )
 target_link_libraries(blas_batch_ct PUBLIC ONEMKL::SYCL::SYCL)
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET blas_batch_ct SOURCES ${BATCH_SOURCES})
+else()
+  target_link_libraries(blas_batch_ct PUBLIC ONEMKL::SYCL::SYCL)
+endif()

tests/unit_tests/blas/extensions/CMakeLists.txt

@@ -32,6 +32,11 @@ if(BUILD_SHARED_LIBS)
       PUBLIC ${CBLAS_INCLUDE}
   )
   target_link_libraries(blas_extensions_rt PUBLIC ONEMKL::SYCL::SYCL)
+  if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+    add_sycl_to_target(TARGET blas_extensions_rt SOURCES ${EXTENSIONS_SOURCES})
+  else()
+    target_link_libraries(blas_extensions_rt PUBLIC ONEMKL::SYCL::SYCL)
+  endif()
 endif()
 
 add_library(blas_extensions_ct OBJECT ${EXTENSIONS_SOURCES})
@@ -45,3 +50,8 @@ target_include_directories(blas_extensions_ct
     PUBLIC ${CBLAS_INCLUDE}
 )
 target_link_libraries(blas_extensions_ct PUBLIC ONEMKL::SYCL::SYCL)
+if (USE_ADD_SYCL_TO_TARGET_INTEGRATION)
+  add_sycl_to_target(TARGET blas_extensions_ct  SOURCES ${EXTENSIONS_SOURCES})
+else()
+  target_link_libraries(blas_extensions_ct PUBLIC ONEMKL::SYCL::SYCL)
+endif()