Skip to content

Commit 6d17941

Browse files
yeshaokaiMMathisLab
authored andcommitted
Shaokai/fix (#48)
* Corrected typo. Added config yamls in setup * Removed config files that are no longer needed * changed work from to pull the repo from git * Added comments to remind people to pay attentino to data folder in the demo notebooks * fixed pypi typo
1 parent 893b2cb commit 6d17941

File tree

10 files changed

+17
-56
lines changed

10 files changed

+17
-56
lines changed

.github/workflows/pytest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,5 @@ jobs:
4343
env:
4444
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
4545
run: |
46-
pip install '.[streamlit]'
46+
pip install git+https://github.com/${{ github.repository }}.git@${{ github.sha }}
4747
pytest tests --timeout=400

amadeusgpt/configs/Custom_template.yaml

Lines changed: 0 additions & 12 deletions
This file was deleted.

amadeusgpt/configs/template.yaml

Lines changed: 0 additions & 11 deletions
This file was deleted.

notebooks/EPM_demo.ipynb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@
5151
"amadeus_root = Path(amadeusgpt.__file__).parent.parent\n",
5252
"config = Config(amadeus_root / \"amadeusgpt/configs/EPM_template.yaml\")\n",
5353
"config['video_info']['scene_frame_number'] = scene_frame_number\n",
54+
"# if you install from pypi or you used the conda file, you have to adjust the path of data folder to\n",
55+
"# repo_root/examples/EPM\n",
5456
"config['data_info']['data_folder'] = amadeus_root / config['data_info']['data_folder']\n",
5557
"\n",
5658
"amadeus = AMADEUS(config)\n",

notebooks/Horse_demo.ipynb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
"config = Config(amadeus_root / \"amadeusgpt/configs/Horse_template.yaml\")\n",
4242
"\n",
4343
"config['video_info']['scene_frame_number'] = scene_frame_number\n",
44+
"# if you install from pypi or you used the conda file, you have to adjust the path of data folder to\n",
45+
"# repo_root/examples/Horse\n",
4446
"config['data_info']['data_folder'] = amadeus_root / config['data_info']['data_folder'] \n",
4547
"\n",
4648
"amadeus = AMADEUS(config)\n",

notebooks/MABe_demo.ipynb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
"source": [
3939
"amadeus_root = Path(amadeusgpt.__file__).parent.parent\n",
4040
"config = Config(amadeus_root / \"amadeusgpt/configs/MABe_template.yaml\")\n",
41+
"# if you install from pypi or you used the conda file, you have to adjust the path of data folder to\n",
42+
"# repo_root/examples/MABe\n",
4143
"config['data_info']['data_folder'] = amadeus_root / config['data_info']['data_folder']\n",
4244
"\n",
4345
"amadeus = AMADEUS(config)\n",

notebooks/MausHaus_demo.ipynb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@
4343
"config = Config(amadeus_root / \"amadeusgpt/configs/MausHaus_template.yaml\")\n",
4444
"\n",
4545
"config['video_info']['scene_frame_number'] = scene_frame_number\n",
46-
"\n",
46+
"# if you install from pypi or you used the conda file, you have to adjust the path of data folder to\n",
47+
"# repo_root/examples/MausHaus\n",
4748
"config['data_info']['data_folder'] = amadeus_root / config['data_info']['data_folder']\n",
4849
"\n",
4950
"amadeus = AMADEUS(config)\n",

notebooks/custom_mouse_video.ipynb

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"cells": [
33
{
44
"cell_type": "code",
5-
"execution_count": 1,
5+
"execution_count": null,
66
"id": "f01f49c5",
77
"metadata": {},
88
"outputs": [],
@@ -15,7 +15,7 @@
1515
},
1616
{
1717
"cell_type": "code",
18-
"execution_count": 2,
18+
"execution_count": null,
1919
"id": "bceb3204-2a87-4671-8135-2533a7a51771",
2020
"metadata": {},
2121
"outputs": [],
@@ -41,37 +41,10 @@
4141
},
4242
{
4343
"cell_type": "code",
44-
"execution_count": 3,
44+
"execution_count": null,
4545
"id": "be76dc87-fbe8-452f-b85c-2af3e95a03bf",
4646
"metadata": {},
47-
"outputs": [
48-
{
49-
"name": "stdout",
50-
"output_type": "stream",
51-
"text": [
52-
"Project created at temp_result_folder. Results will be saved to temp_result_folder\n",
53-
"The project will load video files (*..mp4) and optionally keypoint files from temp_data_folder\n",
54-
"A copy of the project config file is saved at temp_result_folder/config.yaml\n",
55-
"{'data_info': {'data_folder': 'temp_data_folder',\n",
56-
" 'result_folder': 'temp_result_folder',\n",
57-
" 'video_suffix': '.mp4'},\n",
58-
" 'llm_info': {'max_tokens': 4096, 'temperature': 1.0}}\n",
59-
"No video files found in the data folder temp_data_folder. Please check the data folder and the video suffix\n"
60-
]
61-
},
62-
{
63-
"ename": "AttributeError",
64-
"evalue": "'AMADEUS' object has no attribute 'sandbox'",
65-
"output_type": "error",
66-
"traceback": [
67-
"\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
68-
"\u001b[0;31mAttributeError\u001b[0m Traceback (most recent call last)",
69-
"Cell \u001b[0;32mIn[3], line 13\u001b[0m\n\u001b[1;32m 10\u001b[0m config[\u001b[38;5;124m\"\u001b[39m\u001b[38;5;124mscene_frame_number\u001b[39m\u001b[38;5;124m\"\u001b[39m] \u001b[38;5;241m=\u001b[39m scene_frame_number\n\u001b[1;32m 12\u001b[0m amadeus \u001b[38;5;241m=\u001b[39m AMADEUS(config)\n\u001b[0;32m---> 13\u001b[0m video_file_paths \u001b[38;5;241m=\u001b[39m \u001b[43mamadeus\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43mget_video_file_paths\u001b[49m\u001b[43m(\u001b[49m\u001b[43m)\u001b[49m\n\u001b[1;32m 14\u001b[0m \u001b[38;5;28mprint\u001b[39m (video_file_paths)\n",
70-
"File \u001b[0;32m~/AmadeusGPT-dev/amadeusgpt/main.py:121\u001b[0m, in \u001b[0;36mAMADEUS.get_video_file_paths\u001b[0;34m(self)\u001b[0m\n\u001b[1;32m 120\u001b[0m \u001b[38;5;28;01mdef\u001b[39;00m \u001b[38;5;21mget_video_file_paths\u001b[39m(\u001b[38;5;28mself\u001b[39m) \u001b[38;5;241m-\u001b[39m\u001b[38;5;241m>\u001b[39m \u001b[38;5;28mlist\u001b[39m[\u001b[38;5;28mstr\u001b[39m]:\n\u001b[0;32m--> 121\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m \u001b[38;5;28;43mself\u001b[39;49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43msandbox\u001b[49m\u001b[38;5;241m.\u001b[39mvideo_file_paths\n",
71-
"\u001b[0;31mAttributeError\u001b[0m: 'AMADEUS' object has no attribute 'sandbox'"
72-
]
73-
}
74-
],
47+
"outputs": [],
7548
"source": [
7649
"scene_frame_number = 400\n",
7750
"\n",

setup.cfg

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ dev =
5252
static/*.*
5353
static/images/*.*
5454
static/styles/*.*
55+
configs/Horse_template.yaml
56+
configs/EPM_template.yaml
57+
configs/MausHaus_template.yaml
58+
configs/MABe_template.yaml
5559

5660
[options.entry_points]
5761
console_scripts =

0 commit comments

Comments
 (0)