Worker warning + weights error handling

- Added signal to emit warning from worker (not functional for now)

- Added clearer warning when weights are not compatible in training

Author: C-Achard

napari_cellseg3d/log_utility.py

@@ -1,4 +1,5 @@
 import threading
+import warnings
 
 from qtpy import QtCore
 from qtpy.QtGui import QTextCursor
@@ -79,3 +80,10 @@ def print_and_log(self, text, printing=True):
             )
         finally:
             self.lock.release()
+
+    def warn(self, warning):
+        self.lock.acquire()
+        try:
+            warnings.warn(warning)
+        finally:
+            self.lock.release()

napari_cellseg3d/model_workers.py

@@ -149,10 +149,12 @@ def show_progress(count, block_size, total_size):
 class LogSignal(WorkerBaseSignals):
     """Signal to send messages to be logged from another thread.
 
-    Separate from Worker instances as indicated `here`_"""
+    Separate from Worker instances as indicated `here`_"""  # TODO link ?
 
     log_signal = Signal(str)
     """qtpy.QtCore.Signal: signal to be sent when some text should be logged"""
+    warn_signal = Signal(str)
+    """qtpy.QtCore.Signal: signal to be sent when some warning should be emitted in main thread"""
 
     # Should not be an instance variable but a class variable, not defined in __init__, see
     # https://stackoverflow.com/questions/2970312/pyqt4-qtcore-pyqtsignal-object-has-no-attribute-connect
@@ -213,6 +215,7 @@ def __init__(
         super().__init__(self.inference)
         self._signals = LogSignal()  # add custom signals
         self.log_signal = self._signals.log_signal
+        self.warn_signal = self._signals.warn_signal
         ###########################################
         ###########################################
         self.device = device
@@ -252,6 +255,10 @@ def log(self, text):
         """
         self.log_signal.emit(text)
 
+    def warn(self, warning):
+        """Sends a warning to main thread"""
+        self.warn_signal.emit(warning)
+
     def log_parameters(self):
 
         self.log("-" * 20)
@@ -647,7 +654,10 @@ def __init__(
         super().__init__(self.train)
         self._signals = LogSignal()
         self.log_signal = self._signals.log_signal
+        self.warn_signal = self._signals.warn_signal
 
+        self._weight_error = False
+        #############################################
         self.device = device
         self.model_dict = model_dict
         self.weights_path = weights_path
@@ -669,7 +679,7 @@ def __init__(
 
         self.train_files = []
         self.val_files = []
-
+        #######################################
         self.downloader = WeightsDownloader()
 
     def set_download_log(self, widget):
@@ -683,6 +693,10 @@ def log(self, text):
         """
         self.log_signal.emit(text)
 
+    def warn(self, warning):
+        """Sends a warning to main thread"""
+        self.warn_signal.emit(warning)
+
     def log_parameters(self):
 
         self.log("-" * 20)
@@ -726,6 +740,13 @@ def log_parameters(self):
 
         if self.weights_path is not None:
             self.log(f"Using weights from : {self.weights_path}")
+            if self._weight_error:
+                self.log(
+                    ">>>>>>>>>>>>>>>>>\n"
+                    "WARNING:\nChosen weights were incompatible with the model,\n"
+                    "the model will be trained from random weights\n"
+                    "<<<<<<<<<<<<<<<<<\n"
+                )
 
         # self.log("\n")
         self.log("-" * 20)
@@ -959,7 +980,8 @@ def train(self):
                     "the model will be trained from random weights"
                 )
                 self.log(warn)
-                warnings.warn(warn)
+                self.warn(warn)
+                self._weight_error = True
 
         if self.device.type == "cuda":
             self.log("\nUsing GPU :")

napari_cellseg3d/plugin_model_inference.py

@@ -599,6 +599,7 @@ def start(self):
 
             self.worker.started.connect(self.on_start)
             self.worker.log_signal.connect(self.log.print_and_log)
+            self.worker.warn_signal.connect(self.log.warn)
             self.worker.yielded.connect(yield_connect_show_res)
             self.worker.errored.connect(
                 yield_connect_show_res

napari_cellseg3d/plugin_model_training.py

@@ -857,6 +857,7 @@ def start(self):
             [btn.setVisible(False) for btn in self.close_buttons]
 
             self.worker.log_signal.connect(self.log.print_and_log)
+            self.worker.warn_signal.connect(self.log.warn)
 
             self.worker.started.connect(self.on_start)