Skip to content

Commit f6711c3

Browse files
committed
Improve filepath messages
1 parent 6605081 commit f6711c3

File tree

3 files changed

+23
-12
lines changed

3 files changed

+23
-12
lines changed

napari_cellseg3d/code_models/model_framework.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,16 +245,22 @@ def _toggle_weights_path(self):
245245
self.custom_weights_choice, self.weights_filewidget
246246
)
247247

248-
def create_dataset_dict_no_labs(self):
249-
"""Creates unsupervised data dictionary for MONAI transforms and training."""
248+
def get_unsupervised_image_filepaths(self):
250249
volume_directory = Path(
251250
self.unsupervised_images_filewidget.text_field.text()
252251
)
252+
253253
if not volume_directory.exists():
254254
raise ValueError(f"Data folder {volume_directory} does not exist")
255-
images_filepaths = sorted(Path.glob(volume_directory, "*.tif"))
255+
return sorted(Path.glob(volume_directory, "*.tif"))
256+
257+
def create_dataset_dict_no_labs(self):
258+
"""Creates unsupervised data dictionary for MONAI transforms and training."""
259+
images_filepaths = self.get_unsupervised_image_filepaths()
256260
if len(images_filepaths) == 0:
257-
raise ValueError(f"Data folder {volume_directory} is empty")
261+
raise ValueError(
262+
f"Data folder {self.unsupervised_images_filewidget.text_field.text()} is empty"
263+
)
258264

259265
logger.info("Images :")
260266
for file in images_filepaths:

napari_cellseg3d/code_plugins/plugin_base.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ def __init__(
389389
# Validation images widget
390390
self.unsupervised_images_filewidget = ui.FilePathWidget(
391391
description="Training directory",
392-
file_function=self.load_validation_images_dataset,
392+
file_function=self.load_unsup_images_dataset,
393393
parent=self,
394394
)
395395
self.unsupervised_images_filewidget.setVisible(False)
@@ -421,19 +421,23 @@ def load_dataset_paths(self):
421421
def load_image_dataset(self):
422422
"""Show file dialog to set :py:attr:`~images_filepaths`"""
423423
filenames = self.load_dataset_paths()
424-
logger.debug(f"image filenames : {filenames}")
425424
if filenames:
425+
logger.info("Images loaded :")
426+
for f in filenames:
427+
logger.info(f"{str(Path(f).name)}")
426428
self.images_filepaths = [str(path) for path in sorted(filenames)]
427429
path = str(Path(filenames[0]).parent)
428430
self.image_filewidget.text_field.setText(path)
429431
self.image_filewidget.check_ready()
430432
self._update_default_paths(path)
431433

432-
def load_validation_images_dataset(self):
434+
def load_unsup_images_dataset(self):
433435
"""Show file dialog to set :py:attr:`~val_images_filepaths`"""
434436
filenames = self.load_dataset_paths()
435-
logger.debug(f"val filenames : {filenames}")
436437
if filenames:
438+
logger.info("Images loaded (unsupervised training) :")
439+
for f in filenames:
440+
logger.info(f"{str(Path(f).name)}")
437441
self.validation_filepaths = [
438442
str(path) for path in sorted(filenames)
439443
]
@@ -445,8 +449,10 @@ def load_validation_images_dataset(self):
445449
def load_label_dataset(self):
446450
"""Show file dialog to set :py:attr:`~labels_filepaths`"""
447451
filenames = self.load_dataset_paths()
448-
logger.debug(f"labels filenames : {filenames}")
449452
if filenames:
453+
logger.info("Labels loaded :")
454+
for f in filenames:
455+
logger.info(f"{str(Path(f).name)}")
450456
self.labels_filepaths = [str(path) for path in sorted(filenames)]
451457
path = str(Path(filenames[0]).parent)
452458
self.labels_filewidget.text_field.setText(path)
@@ -477,13 +483,13 @@ def extract_dataset_paths(paths):
477483
return None
478484
return str(Path(paths[0]).parent)
479485

480-
481486
def _check_all_filepaths(self):
482487
self.image_filewidget.check_ready()
483488
self.labels_filewidget.check_ready()
484489
self.results_filewidget.check_ready()
485490
self.unsupervised_images_filewidget.check_ready()
486491

492+
487493
class BasePluginUtils(BasePluginFolder):
488494
"""Small subclass used to have centralized widgets layer and result path selection in utilities"""
489495

@@ -516,4 +522,3 @@ def _update_default_paths(self, path=None):
516522
logger.debug(f"Trying to update default with {default_path}")
517523
if default_path is not None:
518524
self.utils_default_paths.append(default_path)
519-

napari_cellseg3d/interface.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1258,7 +1258,7 @@ def open_folder_dialog(
12581258
):
12591259
default_path = utils.parse_default_path(possible_paths)
12601260

1261-
logger.info(f"Default : {default_path}")
1261+
logger.debug(f"Default : {default_path}")
12621262
return QFileDialog.getExistingDirectory(
12631263
widget, "Open directory", default_path # + "/.."
12641264
)

0 commit comments

Comments
 (0)