Skip to content

Commit ef22534

Browse files
authored
Check deployment workflow during PR (#38)
* Check deployment workflow during PR * Give a more expressive name for pypi upload workflow * Fix greeting workflow
1 parent 3f7cf84 commit ef22534

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/greetings.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Greetings
22

3-
on: [pull_request, issues]
3+
on: [pull_request_target, issues]
44

55
jobs:
66
greeting:

.github/workflows/test_and_deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This workflows will upload a Python Package using Twine when a release is created
22
# For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries
33

4-
name: tests
4+
name: Test and PyPI upload
55

66
on:
77
push:
@@ -57,7 +57,6 @@ jobs:
5757
# github secrets (see readme for details)
5858
needs: [test]
5959
runs-on: ubuntu-latest
60-
if: contains(github.ref, 'tags')
6160
steps:
6261
- uses: actions/checkout@v2
6362
- name: Set up Python
@@ -69,6 +68,7 @@ jobs:
6968
python -m pip install --upgrade pip
7069
pip install -U setuptools setuptools_scm wheel twine build
7170
- name: Build and publish
71+
if: contains(github.ref, 'tags')
7272
env:
7373
TWINE_USERNAME: __token__
7474
TWINE_PASSWORD: ${{ secrets.TWINE_API_KEY }}

0 commit comments

Comments
 (0)