Fix off-by-one error in parameter validation loop in no-invalid-scriptlets rule

scripthunter7 · scripthunter7 · commit 52f58d3ba091 · 2025-12-19T09:41:18.000+01:00
- Moved `i += 1` before `nextParameterData = scriptletData.parameters[i]` assignment
- Ensures nextParameterData correctly references the next parameter after incrementing index
- Prevents accessing wrong parameter data when validating scriptlet parameters
diff --git a/src/rules/no-invalid-scriptlets.ts b/src/rules/no-invalid-scriptlets.ts
@@ -225,8 +225,8 @@ export default defineRule({
                             node: scriptletRuleBody,
                         });
 
-                        nextParameterData = scriptletData.parameters[i];
                         i += 1;
+                        nextParameterData = scriptletData.parameters[i];
                     }
                 }
             },

Original file line number	Diff line number	Diff line change
`@@ -225,8 +225,8 @@ export default defineRule({`
`225`	`225`	`node: scriptletRuleBody,`
`226`	`226`	`});`
`227`	`227`
`228`		`- nextParameterData = scriptletData.parameters[i];`
`229`	`228`	`i += 1;`
	`229`	`+ nextParameterData = scriptletData.parameters[i];`
`230`	`230`	`}`
`231`	`231`	`}`
`232`	`232`	`},`