Skip to content

Commit 52c04a3

Browse files
committed
proxy: imp docs
1 parent 91dcdd2 commit 52c04a3

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

proxy/proxy.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -753,13 +753,11 @@ func (p *Proxy) cacheWorks(dctx *DNSContext) (ok bool) {
753753
var reason string
754754
switch {
755755
case dctx.CustomUpstreamConfig != nil && dctx.CustomUpstreamConfig.cache == nil:
756-
// In case of custom upstream cache is not configured, the global proxy
757-
// cache cannot be used because different upstreams can return different
758-
// results.
756+
// If custom upstreams are used but the custom upstream cache is
757+
// disabled, return false to prevent storing results in the global
758+
// cache.
759759
//
760760
// See https://github.com/AdguardTeam/dnsproxy/issues/169.
761-
//
762-
// TODO(e.burkov): It probably should be decided after resolve.
763761
reason = "custom upstreams cache is not configured"
764762
case p.cache == nil &&
765763
(dctx.CustomUpstreamConfig == nil || dctx.CustomUpstreamConfig.cache == nil):

0 commit comments

Comments
 (0)