all: imp docs, style

Author: masterkusok

proxy/cache.go

@@ -245,6 +245,8 @@ func (c *cache) get(req *dns.Msg) (ci *cacheItem, expired bool, key []byte) {
 	return ci, expired, key
 }
 
+// isOptimisticExpired returns true if cache is optimistic and expired item
+// should be deleted explicitly.  ci must not be nil.
 func (c *cache) isOptimisticExpired(ci *cacheItem) (expired bool) {
 	return c.optimistic && uint32(time.Since(ci.createdTime).Seconds()) > ci.ttl+c.optimisticMaxAge
 }

proxy/cache_internal_test.go

@@ -108,20 +108,17 @@ func TestCache_expired(t *testing.T) {
 		wantTTL:    defaultTestTTL,
 		optimistic: false,
 	}, {
-		name: "realistic_miss",
-
+		name:       "realistic_miss",
 		ttl:        0,
 		wantTTL:    0,
 		optimistic: false,
 	}, {
-		name: "optimistic_hit",
-
+		name:       "optimistic_hit",
 		ttl:        defaultTestTTL,
 		wantTTL:    defaultTestTTL,
 		optimistic: true,
 	}, {
-		name: "optimistic_expired",
-
+		name:       "optimistic_expired",
 		ttl:        0,
 		wantTTL:    testOptimisticTTL,
 		optimistic: true,