upstream: imp code

Mizzick · Mizzick · commit afe379e7d31d · 2025-04-07T10:51:11.000+07:00
diff --git a/upstream/upstream.go b/upstream/upstream.go
@@ -386,8 +386,7 @@ func newDialerInitializer(u *url.URL, opts *Options) (di DialerInitializer) {
 		l = slog.Default()
 	}
 
-	// TODO(e.burkov):  Add netutil.IsValidIPPortString.
-	if _, err := netip.ParseAddrPort(u.Host); err == nil {
+	if netutil.IsValidIPPortString(u.Host) {
 		// Don't resolve the address of the server since it's already an IP.
 		handler := bootstrap.NewDialContext(opts.Timeout, l, u.Host)
 

Original file line number	Diff line number	Diff line change
`@@ -386,8 +386,7 @@ func newDialerInitializer(u url.URL, opts Options) (di DialerInitializer) {`
`386`	`386`	`l = slog.Default()`
`387`	`387`	`}`
`388`	`388`
`389`		`- // TODO(e.burkov): Add netutil.IsValidIPPortString.`
`390`		`- if _, err := netip.ParseAddrPort(u.Host); err == nil {`
	`389`	`+ if netutil.IsValidIPPortString(u.Host) {`
`391`	`390`	`// Don't resolve the address of the server since it's already an IP.`
`392`	`391`	`handler := bootstrap.NewDialContext(opts.Timeout, l, u.Host)`
`393`	`392`