feat: Add fallback support for modern Kubernetes labels in pod discovery #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves pod discovery logic to support both legacy and modern Kubernetes labeling conventions for Istio service mesh metrics collection.
Problem
The SMAnalyzer was failing to find pods for services that use modern Kubernetes labels (
app.kubernetes.io/name) instead of the legacyapplabel, resulting in "no pods found for service" errors for properly configured Istio deployments.Impact
This change ensures the SMAnalyzer works with both traditional and modern Kubernetes deployments, following current Kubernetes and Istio best practices for labeling.