Skip to content

Commit 705f036

Browse files
authored
Merge pull request #3 from AdobeDevXSC/new-hero
New hero
2 parents 761e47e + 9a1d86b commit 705f036

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

blocks/cards/cards.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
/* default cards css */
2+
.cards {
3+
position: relative;
4+
z-index: 1;
5+
}
26
.cards > ul {
37
display: grid;
48
grid-template-columns: 1fr;

blocks/hero/hero.css

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@ main .hero-container > div {
66

77
main .hero-container {
88
padding: 0;
9+
position: relative;
10+
z-index: -1;
911
}
1012

1113
.hero {
1214
position: relative;
1315
padding: 32px;
14-
min-height: 275px;
16+
min-height: 375px;
1517
}
1618

1719
.hero h1,
@@ -24,6 +26,7 @@ main .hero-container {
2426

2527
.hero h1 {
2628
margin-bottom: 0;
29+
margin-top: 200px;
2730
}
2831

2932
.hero h4 {
@@ -32,7 +35,8 @@ main .hero-container {
3235
}
3336

3437
.hero picture {
35-
position: absolute;
38+
/* position: absolute; */
39+
position: fixed;
3640
z-index: -1;
3741
inset: 0;
3842
object-fit: cover;

scripts/scripts.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import decorate from '../blocks/hero/hero.js';
12
import {
23
sampleRUM,
34
buildBlock,

styles/styles.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,11 @@ main img {
208208
/* sections */
209209
main .section {
210210
padding: 16px;
211+
background-color: white;
211212
}
212213

214+
215+
213216
main .main-wrapper .section:not(:first-of-type) {
214217
border-radius: 10px;
215218
box-shadow: 0 4px 20px rgba(0 0 0 / 10%);

0 commit comments

Comments
 (0)