OWS-634: Allow deployment config to load a custom properties file

Author: janakmulani

core/src/main/java/net/sourceforge/jnlp/config/DeploymentConfiguration.java

@@ -165,10 +165,10 @@ static boolean checkUrl(final URL file) {
      *
      * @throws ConfigurationException if it encounters a fatal error.
      */
-    public void load(File... propFile) throws ConfigurationException {
+    public void load() throws ConfigurationException {
         LOG.debug("Start DeploymentConfiguration.load()");
         try {
-            load(true, propFile);
+            load(true);
         } catch (final MalformedURLException ex) {
             throw new ConfigurationException(ex.toString());
         } finally {
@@ -184,11 +184,12 @@ public void load(File... propFile) throws ConfigurationException {
      * resorting to the default values
      * @throws ConfigurationException if it encounters a fatal error.
      */
-    public void load(final boolean fixIssues, File... propFile ) throws ConfigurationException, MalformedURLException {
+    public void load(final boolean fixIssues) throws ConfigurationException, MalformedURLException {
+        final String owsUserPropertiesFilePath = System.getProperty("owsUserPropertiesFilePath");
         final SecurityManager sm = System.getSecurityManager();
         if (sm != null) {
-            if (propFile.length > 0) {
-                sm.checkRead(clean(propFile[0].getAbsolutePath()));
+            if (owsUserPropertiesFilePath != null) {
+                sm.checkRead(owsUserPropertiesFilePath);
             } else {
                 sm.checkRead(userDeploymentFileDescriptor.getFullPath());
             }
@@ -208,7 +209,7 @@ public void load(final boolean fixIssues, File... propFile ) throws Configuratio
         /*
          * Third, read the user's subdirResult deployment.properties file or the custom config properties
          */
-        userPropertiesFile = propFile.length > 0 ? propFile[0] : userDeploymentFileDescriptor.getFile();
+        userPropertiesFile = owsUserPropertiesFilePath != null ? new File(owsUserPropertiesFilePath) : userDeploymentFileDescriptor.getFile();
         final URL userPropertiesUrl = userPropertiesFile.toURI().toURL();
         final Map<String, Setting> userProperties = loadProperties(ConfigType.USER, userPropertiesUrl, false);
         userComments = loadComments(userPropertiesUrl);

core/src/main/java/net/sourceforge/jnlp/runtime/JNLPRuntime.java

@@ -459,13 +459,7 @@ private static class DeploymentConfigurationHolder {
         static {
             DeploymentConfiguration config = new DeploymentConfiguration();
             try {
-                final String owsUserPropertiesFilename = System.getProperty("owsUserPropertiesFilename");
-                if (owsUserPropertiesFilename != null) {
-                    LOG.debug("Loading config from file {} ", owsUserPropertiesFilename);
-                    config.load(new File(owsUserPropertiesFilename));
-                } else {
-                    config.load();
-                }
+                config.load();
                 config.copyTo(System.getProperties());
             } catch (ConfigurationException ex) {
                 LOG.info("Fatal error while reading the configuration, continuing with empty. Please fix");