fix package install code; importer cleanups

Author: briantoby

GSASII/GSASIIctrlGUI.py

@@ -10458,25 +10458,34 @@ def SelectPkgInstall(event):
     if sel is None: return
     if not any(sel): return
     pkgs = [choices[i][0] for i,f in enumerate(sel) if f]
+    wx.BeginBusyCursor()
+    pdlg = wx.ProgressDialog('Updating','Installing Python packages; this can take a while',
+                    parent=G2frame)
     if GSASIIpath.condaTest():
         patch_condarc()
         if not GSASIIpath.condaTest(True):
             GSASIIpath.addCondaPkg()
         err = GSASIIpath.condaInstall(pkgs)
         if err:
             print(f'Error from conda: {err}')
+            wx.EndBusyCursor()
+            pdlg.Destroy()
             return
     else:
         err = GSASIIpath.pipInstall(pkgs)
         if err:
             print(f'Error from pip: {err}')
+            wx.EndBusyCursor()
+            pdlg.Destroy()
             return
+    wx.EndBusyCursor()
+    pdlg.Destroy()
     msg = '''You must restart GSAS-II to access the importer(s) 
-requiring the installed package(s). 
+requiring the package(s) just installed.
 
-Select "Yes" to save, "No" to skip the save, or "Cancel"
-to discontinue the restart process and continue GSAS-II 
-without the importer(s). 
+Select "Yes" to save and restart, "No" to restart without
+the save, or "Cancel" to discontinue the restart process 
+and continue use of GSAS-II without the importer(s).
 
 If "Yes", GSAS-II will reopen the project after the update.
 '''

GSASII/GSASIIpath.py

@@ -2265,9 +2265,14 @@ def condaInstall(packageList):
                   '\nConsider using the "conda install conda" command')
         return None
     try:
+        print(f'preparing to install {packageList}'+
+                  '\nThis can take a while')
+        # the next line works, but the subsequent cli is considered more stable
+        #conda.cli.main('install',  '-y', *packageList)
+        # this is considered to be supported in the long term
         (out, err, rc) = conda.cli.python_api.run_command(
             conda.cli.python_api.Commands.INSTALL,packageList,
-            search_path=('conda-forge'),
+#            search_path=('conda-forge'),   # broken!
 #    use_exception_handler=True#, stdout=sys.stdout,
             stderr=sys.stderr)
         #print('rc=',rc)

GSASII/imports/G2pwd_BrukerBRML.py

@@ -8,7 +8,7 @@
 try:
     import xmltodict as xml
 except Exception as msg:
-    if GSASIIpath.GetConfigValue('debug'): print(f'Debug: xmltodict error = {msg}')
+    #if GSASIIpath.GetConfigValue('debug'): print(f'Debug: xmltodict error = {msg}')
     xml = None
 import GSASIIobj as G2obj
 import GSASIIfiles as G2fil

GSASII/imports/G2pwd_MIDAS.py

@@ -58,7 +58,7 @@ def ContentsValidator(self, filename):
         '''
         fp = None
         try:
-            fp = zarr.open(filename, 'r')
+            fp = zarr.open(filename, mode='r')
             if all([(i in fp) for i in self.midassections]): # are expected MIDAS sections present?
                 self.mode = 'midas'
                 return True # must be present for Midas output