why error w/subprocess still running? try changing order of .terminate

Author: briantoby

GSASII/nistlat.py

@@ -187,9 +187,9 @@ def ReduceCell(center, cellin, mode=0, deltaV=0, output=None):
         print(line)
         return celldict
     finally:
+        p.terminate()
         p.stdout.close()
         p.stderr.close()
-        p.terminate()
     if len(celldict['output']) == 0 or len(err) > 0:
         print('Error:' ,err.decode())
     return celldict
@@ -254,9 +254,9 @@ def ConvCell(redcell):
         return None
         #return cell
     finally:
+        p.terminate()
         p.stdout.close()
         p.stderr.close()
-        p.terminate()
     if len(err) >  0:
         print('Error:' ,err.decode())
     return (cell,center,setting,mat)
@@ -324,9 +324,9 @@ def CompareCell(cell1, center1, cell2, center2, tolerance=3*[0.2]+3*[1],
     if output: fp = open(output,'w')
     # read output and parse
     lines = [b.decode() for b in p.stdout.readlines()]
+    p.terminate()
     p.stdout.close()
     p.stderr.close()
-    p.terminate()
     if fp:
         for line in lines: _emulateLP(line,fp)
         fp.close()
@@ -446,9 +446,9 @@ def CellSymSearch(cellin, center, tolerance=3*[0.2]+3*[1], mode=0,
 
     d = 1
     lines = [b.decode() for b in p.stdout.readlines()]
+    p.terminate()
     p.stdout.close()
     p.stderr.close()
-    p.terminate()
     fp = None
     if output: fp = open(output,'w')
     if fp:
@@ -571,9 +571,9 @@ def CellSymSearch(cellin, center, tolerance=3*[0.2]+3*[1], mode=0,
         print(line)
         return celldict
 #    finally:
+#        p.terminate()
 #        p.stdout.close()
 #        p.stderr.close()
-#        p.terminate()
     if len(symCellList) == 0 or len(err) > 0:
         print('Error:' ,err.decode())
     return symCellList