FIX: runtime errors when compiled with flang (#193)

tacaswell · web-flow · commit d457fcf1c740 · 2025-06-25T11:13:44.000-05:00
* MNT: add missing declarations

* FIX: get correct results with flang

Issue was flang picking up some other version of ACOSD.

* MNT: add additional external function declarations
diff --git a/sources/powsubs/psvfcjexpo.for b/sources/powsubs/psvfcjexpo.for
@@ -25,6 +25,8 @@
 
 !INCLUDE STATEMENTS:
       REAL*4 SIND,COSD,TAND,ACOSD
+! External function declarations
+      EXTERNAL SIND,COSD,TAND,ACOSD
 
 !LOCAL VARIABLES:
 
@@ -310,4 +312,4 @@ C
       HLPART = DYDB
       RETURN
       END
-      
+
diff --git a/sources/powsubs/psvfcjo.for b/sources/powsubs/psvfcjo.for
@@ -25,6 +25,8 @@
 
 !INCLUDE STATEMENTS:
       REAL*4 SIND,COSD,TAND,ACOSD
+! External function declarations 
+      EXTERNAL SIND,COSD,TAND,ACOSD
 
 !LOCAL VARIABLES:
 
@@ -41,6 +43,7 @@
       REAL*4        DYDB                
       REAL*4        SIN2THETA2          ! sin(2theta)**2
       REAL*4        COS2THETA           ! cos(2theta)
+      REAL*4        COS2THETA2          ! cos(2theta)**2
       REAL*4        SIN2THETA           ! sin(2THETA)
       REAL*4        SINDELTA            ! sin(Delta)
       REAL*4        COSDELTA            ! cos(Delta)
diff --git a/sources/pypowder.for b/sources/pypowder.for
@@ -141,6 +141,7 @@ Cf2py depend(NPTS) PRFUNC
       INTEGER*4 NPTS
       REAL*4 TTHETA,SIG,GAM,SPH
       REAL*4 DTT(0:NPTS-1),PRFUNC(0:NPTS-1)
+      REAL*4 DPRDT,SIGPART,GAMPART,SLPART,HLPART
       DO I=0,NPTS-1
         CALL PSVFCJO(DTT(I)*100.,TTHETA*100.,SIG,GAM,SPH/2.0,SPH/2.0,
      1     PRFUNC(I),DPRDT,SIGPART,GAMPART,SLPART,HLPART)
diff --git a/sources/texturesubs/plmpsi.for b/sources/texturesubs/plmpsi.for
@@ -11,6 +11,9 @@
       REAL*4        P                   !Value returned
 
 !INCLUDE STATEMENTS:
+      REAL*4 SIND,COSD 
+! External function declarations
+      EXTERNAL SIND,COSD
 
 !LOCAL VARIABLES:
                                                  
