FIX: fix escaping in re expressions #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future versions of Python will have SyntaxError on invalid (to Python) escape codes.
Collaborator
Author
|
"power-cycled" to get CI to run :) |
briantoby
added a commit
that referenced
this pull request
Jan 21, 2025
…CifRW files replaced w/conda package)
Collaborator
|
The PyCifRW (CifFiles) package was previously distributed as part of GSAS-II with a now out-of-date version. Originally that was all we could do, but since it is [now] in Conda-forge & PyPI, better to use the current package (as it addresses the fixes above). If this introduces bugs, we will want to fix them in GSAS-II rather than say with an old package. The cleanup to GSASII/GSASIIexprGUI.py (and then some) was applied in ae319c3. Closing PR as no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future versions of Python will have SyntaxError on invalid (to Python) escape codes.