Skip to content

Conversation

@tacaswell
Copy link
Collaborator

Does two things:

  • do not check into git or track git_verinfo.py as soon as you commit it, it is wrong!
  • adds pycifrw to pyproject.toml

@briantoby
Copy link
Collaborator

I'll take a look at this PR when I get a chance.

I can see that I'm using git_verinfo.py for multiple roles that I probably need to be split up. I'll have to think about that more.

@briantoby
Copy link
Collaborator

  • fixed the dual use of git_verinfo.py by creating an untracked file (not yet used)
  • cleaned up self tests
  • copy exe's for pixi install-editable (unix only)

@briantoby briantoby merged commit d35bb5b into AdvancedPhotonSource:develop Feb 19, 2025
8 checks passed
@tacaswell tacaswell deleted the ciffile_dep branch February 20, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants