fix(compatibility): change hook registration priorities to improve compatibility with other plugins

Fixes #56

Author: CoderCow

Implementation/ProtectorPlugin.cs

@@ -52,6 +52,7 @@ public class ProtectorPlugin: TerrariaPlugin, IDisposable {
     protected PluginInfo PluginInfo { get; private set; }
     protected Configuration Config { get; private set; }
     protected GetDataHookHandler GetDataHookHandler { get; private set; }
+    protected GetDataHookHandler GetDataHookHandlerLate { get; private set; }
     public ChestManager ChestManager { get; private set; }
     public ProtectionManager ProtectionManager { get; private set; }
     protected UserInteractionHandler UserInteractionHandler { get; private set; }
@@ -208,10 +209,9 @@ private void AddHooks() {
       if (this.GetDataHookHandler != null)
         throw new InvalidOperationException("Hooks already registered.");
 
+      // this hook should ideally be registered BEFORE all other plugins
       this.GetDataHookHandler = new GetDataHookHandler(this, true);
-      this.GetDataHookHandler.InvokeTileOnObjectPlacement = false;
       this.GetDataHookHandler.TileEdit += this.Net_TileEdit;
-      this.GetDataHookHandler.ObjectPlacement += this.Net_ObjectPlacement;
       this.GetDataHookHandler.SignEdit += this.Net_SignEdit;
       this.GetDataHookHandler.SignRead += this.Net_SignRead;
       this.GetDataHookHandler.ChestPlace += this.Net_ChestPlace;
@@ -224,6 +224,11 @@ private void AddHooks() {
       this.GetDataHookHandler.DoorUse += this.Net_DoorUse;
       this.GetDataHookHandler.QuickStackNearby += this.Net_QuickStackNearby;
 
+      // this hook should ideally be registered AFTER all other plugins
+      this.GetDataHookHandlerLate = new GetDataHookHandler(this, true, -100);
+      this.GetDataHookHandlerLate.TileEdit += this.Net_TileEditLate;
+      this.GetDataHookHandlerLate.ObjectPlacement += this.Net_ObjectPlacement;
+
       ServerApi.Hooks.GameUpdate.Register(this, this.Game_Update);
       ServerApi.Hooks.WorldSave.Register(this, this.World_SaveWorld);
       GetDataHandlers.PlayerSpawn += this.TShock_PlayerSpawn;
@@ -245,6 +250,13 @@ private void Net_TileEdit(object sender, TileEditEventArgs e) {
       e.Handled = this.UserInteractionHandler.HandleTileEdit(e.Player, e.EditType, e.BlockType, e.Location, e.ObjectStyle);
     }
 
+    private void Net_TileEditLate(object sender, TileEditEventArgs e) {
+      if (this.isDisposed || !this.hooksEnabled || e.Handled)
+        return;
+
+      e.Handled = this.UserInteractionHandler.HandleTileEdit(e.Player, e.EditType, e.BlockType, e.Location, e.ObjectStyle, true);
+    }
+
     private void Net_ObjectPlacement(object sender, ObjectPlacementEventArgs e) {
       if (this.isDisposed || !this.hooksEnabled || e.Handled)
         return;

Implementation/UserInteractionHandler.cs

@@ -2081,18 +2081,25 @@ private bool TradeChestCommand_HelpCallback(CommandArgs args) {
     #endregion
 
     #region [Hook Handlers]
-    public override bool HandleTileEdit(
-      TSPlayer player, TileEditType editType, int blockType, DPoint location, int objectStyle
-    ) {
+    public override bool HandleTileEdit(TSPlayer player, TileEditType editType, int blockType, DPoint location, int objectStyle) {
+      return this.HandleTileEdit(player, editType, blockType, location, objectStyle, false);
+    }
+
+    /// <param name="isLate">
+    ///   if <c>true</c>, then this tile edit handler was invoked after all other plugins.
+    /// </param>
+    public bool HandleTileEdit(TSPlayer player, TileEditType editType, int blockType, DPoint location, int objectStyle, bool isLate) {
       if (this.IsDisposed)
         return false;
       if (base.HandleTileEdit(player, editType, blockType, location, objectStyle))
         return true;
 
       switch (editType) {
         case TileEditType.PlaceTile: {
+          if (!isLate)
+            break;
+
           WorldGen.PlaceTile(location.X, location.Y, blockType, false, true, -1, objectStyle);
-          
           NetMessage.SendData((int)PacketTypes.Tile, -1, player.Index, NetworkText.Empty, 1, location.X, location.Y, blockType, objectStyle);
 
           if (this.Config.AutoProtectedTiles[blockType])