V7 generator - Update workflow to address parallelism issues for windows-latest during build (#1229)

* No longer GeneratePackageOnBuild
* Run dotnet clean before running dotnet build
* Removed .NET 4.5 references
* BuildInParallel set to false in csproj

Author: Kwok-he-Chu

.github/workflows/build-net8.0.yml

@@ -31,11 +31,16 @@ jobs:
         with:
           dotnet-version: 8.0.x
 
+      - name: Clean
+        run: dotnet clean
+
       - name: Restore dependencies
-        run: dotnet restore
+        run: dotnet restore -m:1          # -m:1 disables parallelism and ensures only one build touches /obj. 
 
       - name: Build (debug) in .NET 8.0
-        run: dotnet build --configuration Debug --framework net8.0 --no-restore
+        run: dotnet build --no-restore -m:1 --framework net8.0
+        env:
+          UseSharedCompilation: false     # We are dealing with two sources of parallelism (see matrix) - Adyen.GeneratedMSBuildEditorConfig.editorconfig gets a .lock-file, this prevents another parallel process from accessing the build during the .lock. 
 
       - name: Run unit tests in .NET 8.0
-        run: dotnet test --no-build --configuration Debug --framework net8.0 --no-restore Adyen.Test/Adyen.Test.csproj
+        run: dotnet test --no-build --framework net8.0 Adyen.Test/Adyen.Test.csproj

Adyen/Adyen.csproj

@@ -10,9 +10,9 @@
     <Version>33.0.0</Version>
     <AssemblyVersion>33.0.0</AssemblyVersion>
     <FileVersion>33.0.0</FileVersion>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <IncludeSymbols>true</IncludeSymbols>
     <IncludeSource>true</IncludeSource>
+    <BuildInParallel>false</BuildInParallel>
     <Description>The Adyen API Library for .NET Core allows developers to interact with the Adyen APIs, including Hosted Payment Pages and the Terminal API.</Description>
     <PackageProjectUrl>https://github.com/Adyen/adyen-dotnet-api-library</PackageProjectUrl>
     <RepositoryUrl>https://github.com/Adyen/adyen-dotnet-api-library</RepositoryUrl>
@@ -45,13 +45,6 @@
     <PackageReference Include="System.Text.Json" Version="8.0.6" />
   </ItemGroup>
 
-  <!-- .NET 4.5 references, compilation flags and build options -->
-  <ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
-    <Reference Include="System" />
-    <Reference Include="Microsoft.CSharp" />
-    <Reference Include="System.Web" />
-  </ItemGroup>
-  
   <ItemGroup>
     <None Include="adyen-logo.png" Pack="true" Visible="false" PackagePath="" />
     <None Include="..\README.md" Pack="true" PackagePath="" />