Fix undefined array key "giftcard" in /Helper/GiftcardPayment.php on line 116 (#2883)

* Abstracting the code, removing the console.logs

* Fix : Undefined array key "giftcard" in /Helper/GiftcardPayment.php

* Revert "Abstracting the code, removing the console.logs"

This reverts commit 495ec49.

---------

Co-authored-by: khushboos <khushboo.singhvi@adyen.com>
Co-authored-by: Dimitri BOUTEILLE <dimitri.bouteille@reflet-digital.com>
Co-authored-by: Can Demiralp <can.demiralp@adyen.com>
Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>

Author: 4 people

Helper/GiftcardPayment.php

@@ -108,12 +108,21 @@ public function getQuoteGiftcardTotalBalance(int $quoteId): int
         $totalBalance = 0;
 
         foreach ($stateDataArray as $stateData) {
-            $stateData = json_decode($stateData['state_data'], true);
+            $state = $stateData['state_data'] ?? null;
+            if (!is_string($state)) {
+                continue;
+            }
+
+            $stateData = json_decode($state, true);
+            $giftCardValue = $stateData['giftcard']['balance']['value'] ?? null;
+            if (!is_numeric($giftCardValue)) {
+                continue;
+            }
 
             if (isset($stateData['paymentMethod']['type']) ||
                 isset($stateData['paymentMethod']['brand']) ||
                 $stateData['paymentMethod']['type'] === 'giftcard') {
-                $totalBalance += $stateData['giftcard']['balance']['value'];
+                $totalBalance += $giftCardValue;
             }
         }
 

Test/Unit/Helper/GiftcardPaymentTest.php

@@ -263,6 +263,39 @@ public function testGetQuoteGiftcardTotalBalance(): void
         $this->assertEquals($expectedGiftcardTotalBalance, $totalBalance);
     }
 
+    public function testGetQuoteGiftcardTotalBalanceWithInvalidState(): void
+    {
+        $quoteId = 1;
+
+        $state = <<<JSON
+    {
+      "paymentMethod": {
+        "type": "giftcard",
+        "brand": "svs",
+        "encryptedCardNumber": "PLACEHOLDER_GIFT_CARD_NUMBER",
+        "encryptedSecurityCode": "PLACEHOLDER_GIFT_CARD_PIN"
+      }
+    }
+    JSON;
+
+        $adyenStateDataMock = $this->createConfiguredMock(StateDataCollection::class, [
+            'getStateDataRowsWithQuoteId' => $this->createConfiguredMock(StateDataCollection::class, [
+                'getData' => [
+                    [
+                        'entity_id' => 1,
+                        'quote_id' => 1,
+                        'state_data' => $state
+                    ]
+                ]
+            ])
+        ]);
+
+        $giftcardPaymentHelper = $this->createGiftcardPaymentHelper($adyenStateDataMock);
+        $totalBalance = $giftcardPaymentHelper->getQuoteGiftcardTotalBalance($quoteId);
+
+        $this->assertEquals(0, $totalBalance, 'The total must be equal to 0 because the giftcard key is undefined.');
+    }
+
     private static function discountTestDataProvider(): array
     {
         return [