Refactor tests (Gemini review)

Author: gcatanese

src/__tests__/webhooks/notification.spec.ts

@@ -108,8 +108,8 @@ describe("Notification Tests", function (): void {
 
         expect(notificationRequestItem.amount).toBeDefined();
         expect(notificationRequestItem.additionalData).toBeDefined();
-        expect(notificationRequestItem.additionalData!.orderId).toEqual("12345");
-        expect(notificationRequestItem.additionalData!.customerId).toEqual("67890");
+        expect(notificationRequestItem.additionalData).toHaveProperty("orderId", "12345");
+        expect(notificationRequestItem.additionalData).toHaveProperty("customerId", "67890");
 
     });
 
@@ -133,10 +133,12 @@ describe("Notification Tests", function (): void {
 
         expect(notificationRequestItem.amount).toBeDefined();
         expect(notificationRequestItem.additionalData).toBeDefined();
-        expect(notificationRequestItem.additionalData!.orderId).toEqual("12345");
-        expect(notificationRequestItem.additionalData!.customerId).toEqual("67890");
-        expect(notificationRequestItem.additionalData!["metadata.myKey"]).toEqual("myValue");
-        expect(notificationRequestItem.additionalData!["metadata.anotherKey"]).toEqual("anotherValue");
+        expect(notificationRequestItem.additionalData).toHaveProperty("orderId", "12345");
+        expect(notificationRequestItem.additionalData).toHaveProperty("customerId", "67890");
+        expect(notificationRequestItem.additionalData["metadata.myKey"]).toBeDefined();
+        expect(notificationRequestItem.additionalData["metadata.anotherKey"]).toBeDefined();
+        expect(notificationRequestItem.additionalData["metadata.myKey"]).toEqual("myValue");
+        expect(notificationRequestItem.additionalData["metadata.anotherKey"]).toEqual("anotherValue");
 
     });
 });

src/typings/terminal/predefinedContentHelper.ts

@@ -0,0 +1,103 @@
+/**
+ * PredefinedContentHelper class to parse and manage predefined content reference IDs.
+ */
+export class PredefinedContentHelper {
+    private params: URLSearchParams;
+
+    constructor(referenceId: string) {
+        this.params = new URLSearchParams(referenceId);
+    }
+
+    /**
+     * Extracts and validates the `event` value from the ReferenceID.
+     *
+     * @returns A valid `DisplayNotificationEvent`, otherwise `null`.
+     *
+     * @example
+     * const helper = new PredefinedContentHelper("...&event=PIN_ENTERED");
+     * const event = helper.getEvent(); // "PIN_ENTERED" or null
+     */
+    getEvent(): DisplayNotificationEvent | null {
+        const event = this.params.get("event");
+
+        switch (event) {
+            case "TENDER_CREATED":
+            case "CARD_INSERTED":
+            case "CARD_PRESENTED":
+            case "CARD_SWIPED":
+            case "WAIT_FOR_APP_SELECTION":
+            case "APPLICATION_SELECTED":
+            case "ASK_SIGNATURE":
+            case "CHECK_SIGNATURE":
+            case "SIGNATURE_CHECKED":
+            case "WAIT_FOR_PIN":
+            case "PIN_ENTERED":
+            case "PRINT_RECEIPT":
+            case "RECEIPT_PRINTED":
+            case "CARD_REMOVED":
+            case "TENDER_FINAL":
+            case "ASK_DCC":
+            case "DCC_ACCEPTED":
+            case "DCC_REJECTED":
+            case "ASK_GRATUITY":
+            case "GRATUITY_ENTERED":
+            case "BALANCE_QUERY_STARTED":
+            case "BALANCE_QUERY_COMPLETED":
+            case "LOAD_STARTED":
+            case "LOAD_COMPLETED":
+            case "PROVIDE_CARD_DETAILS":
+            case "CARD_DETAILS_PROVIDED":
+                return event as DisplayNotificationEvent;
+            default:
+                return null;
+        }
+    }
+    getTransactionId(): string | null {
+        return this.params.get("TransactionID");
+    }
+
+    getTimeStamp(): string | null {
+        return this.params.get("TimeStamp");
+    }
+
+    get(key: string): string | null {
+        return this.params.get(key);
+    }
+
+    toObject(): Record<string, string> {
+        const result: Record<string, string> = {};
+        for (const [key, value] of this.params.entries()) {
+            result[key] = value;
+        }
+        return result;
+    }
+}
+
+export enum DisplayNotificationEvent {
+    TENDER_CREATED = "TENDER_CREATED",
+    CARD_INSERTED = "CARD_INSERTED",
+    CARD_PRESENTED = "CARD_PRESENTED",
+    CARD_SWIPED = "CARD_SWIPED",
+    WAIT_FOR_APP_SELECTION = "WAIT_FOR_APP_SELECTION",
+    APPLICATION_SELECTED = "APPLICATION_SELECTED",
+    ASK_SIGNATURE = "ASK_SIGNATURE",
+    CHECK_SIGNATURE = "CHECK_SIGNATURE",
+    SIGNATURE_CHECKED = "SIGNATURE_CHECKED",
+    WAIT_FOR_PIN = "WAIT_FOR_PIN",
+    PIN_ENTERED = "PIN_ENTERED",
+    PRINT_RECEIPT = "PRINT_RECEIPT",
+    RECEIPT_PRINTED = "RECEIPT_PRINTED",
+    CARD_REMOVED = "CARD_REMOVED",
+    TENDER_FINAL = "TENDER_FINAL",
+    ASK_DCC = "ASK_DCC",
+    DCC_ACCEPTED = "DCC_ACCEPTED",
+    DCC_REJECTED = "DCC_REJECTED",
+    ASK_GRATUITY = "ASK_GRATUITY",
+    GRATUITY_ENTERED = "GRATUITY_ENTERED",
+    BALANCE_QUERY_STARTED = "BALANCE_QUERY_STARTED",
+    BALANCE_QUERY_COMPLETED = "BALANCE_QUERY_COMPLETED",
+    LOAD_STARTED = "LOAD_STARTED",
+    LOAD_COMPLETED = "LOAD_COMPLETED",
+    PROVIDE_CARD_DETAILS = "PROVIDE_CARD_DETAILS",
+    CARD_DETAILS_PROVIDED = "CARD_DETAILS_PROVIDED",
+}