provisioning: Ensure we're creating errors for the right things

Signed-off-by: Ikey Doherty <[email protected]>

Author: ikeycode

crates/provisioning/src/commands.rs

@@ -32,9 +32,9 @@ type CommandExec = for<'a> fn(Context<'a>) -> Result<Command, crate::Error>;
 
 /// Map of command names to functions
 static COMMANDS: phf::Map<&'static str, CommandExec> = phf::phf_map! {
-    // "find-disk" => dummy_command,
-    // "create-partition" => dummy_command,
-    // "create-partition-table" => dummy_command,
+    "find-disk" => dummy_command,
+    "create-partition" => dummy_command,
+    "create-partition-table" => dummy_command,
 };
 
 /// Parse a command from a node if possible

crates/provisioning/src/lib.rs

@@ -98,10 +98,9 @@ impl Parser {
                     Err(e) => Either::Right(e),
                 });
 
-        let fatal_errors = errors.iter().filter(|e| match e.severity().unwrap_or(Severity::Error) {
-            Severity::Error => true,
-            _ => true,
-        });
+        let fatal_errors = errors
+            .iter()
+            .filter(|e| matches!(e.severity().unwrap_or(Severity::Error), Severity::Error));
 
         // If we have any fatal errors, bail out
         // TODO: Add an error sink to allow bubbling up of warnings/diagnostics