Skip to content

Conversation

@Aetherinox
Copy link
Owner

v1.2.0

  • feat(github): added support for Github dark theme
  • feat(github): added new colorization options for github themes
  • feat(themes): added new color theme option to change codeblock text color
  • feat(themes): can now force a specific theme on both Github and Opengist snippets
    • append &themename to the end of the gist url
  • change(themes): theme dropdown box moved to "Global" menu tab
  • perf: minor optimization adjustments
  • chore: cleaned up style-sheet management for Github and OpenGist

@Aetherinox Aetherinox merged commit ee96b55 into main Mar 4, 2024
@github-actions
Copy link

github-actions bot commented Mar 4, 2024


Automatic Self-Check - #16

The details of our automated scan for your pull request are listed below. If our scan detected errors, they must be corrected before this pull request will be advanced to the review stage:




About

This pull request includes the following information:

Category Value
Repo obsidian-gistr
Branch: Source main
Branch: Target build-dev
Added Files 0
Modified Files 6
Renamed Files 0
Copied Files 0
Deleted Files 0



📄 dist/main.js

Caution

Errors must be fixed prior to a pull request being reviewed and accepted.
The file dist/main.js contains the following errors:


❌ Avoid assigning inline styles via JavaScript or in HTML. Move these styles to CSS so that they are adaptable by themes and other plugins.
❌ Change all instances of var to const or let. var has function-level scope, and leads to bugs.
❌ Using innerHTML is a security risk. Use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements
❌ Do not utilize setTimeout, utilize Obsidian API -> sleep. E.g: await sleep( X )

Warning

Warnings are suggestions that do not require fixing, but are recommended before this pull request is reviewed and accepted.
The file dist/main.js contains the following warnings:


⚠️ Avoid unnecessary logging or ensure logging only occurs in development environment.
⚠️ A restricted word was found in your code. Obsidian developers do not allow words in strings such as:

  • Obsidian
  • Settings



📄 tests/Gistr Demo/.obsidian/plugins/gistr/main.js

Caution

Errors must be fixed prior to a pull request being reviewed and accepted.
The file tests/Gistr Demo/.obsidian/plugins/gistr/main.js contains the following errors:


❌ Avoid assigning inline styles via JavaScript or in HTML. Move these styles to CSS so that they are adaptable by themes and other plugins.
❌ Change all instances of var to const or let. var has function-level scope, and leads to bugs.
❌ Using innerHTML is a security risk. Use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements
❌ Do not utilize setTimeout, utilize Obsidian API -> sleep. E.g: await sleep( X )

Warning

Warnings are suggestions that do not require fixing, but are recommended before this pull request is reviewed and accepted.
The file tests/Gistr Demo/.obsidian/plugins/gistr/main.js contains the following warnings:


⚠️ Avoid unnecessary logging or ensure logging only occurs in development environment.
⚠️ A restricted word was found in your code. Obsidian developers do not allow words in strings such as:

  • Obsidian
  • Settings



📄 tests/Gistr Demo/.obsidian/plugins/gistr/manifest.json


Note

The file tests/Gistr Demo/.obsidian/plugins/gistr/manifest.json contains no errors





📄 tests/Gistr Demo/.obsidian/workspace.json

Warning

Warnings are suggestions that do not require fixing, but are recommended before this pull request is reviewed and accepted.
The file tests/Gistr Demo/.obsidian/workspace.json contains the following warnings:


⚠️ A restricted word was found in your code. Obsidian developers do not allow words in strings such as:

  • Obsidian
  • Settings



📄 tests/Gistr Demo/Github.md


Note

The file tests/Gistr Demo/Github.md contains no errors





📄 tests/Gistr Demo/OpenGist.md


Note

The file tests/Gistr Demo/OpenGist.md contains no errors





This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Aetherinox Aetherinox deleted the build-dev branch March 5, 2024 20:36
@BinaryServ
Copy link
Collaborator

⚠️ This pull request has been automatically locked since there has not been any recent activity after it was closed.
Please open a new issue for related bugs.

I am a bot reaching out to you with an automated response.

@BinaryServ BinaryServ added the Status 𐄂 Locked Automatically locked by AdminServ for a prolonged period of inactivity label Mar 6, 2025
Repository owner locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Status 𐄂 Locked Automatically locked by AdminServ for a prolonged period of inactivity Type ◦ Pull Request Normal pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants