🐛 Bug: CMD windows opens then closes, can't run the script.

[kenshyura]

When I execute the batch script from Windows explorer, a CMD windows opens and then closes inmdiately, anyway I can run the script if I manually open a CMD windows and then execute the batch script from there.
I use to make batch scripts and powershell scripts but I can't find a way to solve this.
Thank you.

PS: I found that my path to the .bat file is "d:\Software 2025!!WPI 2025 GUI 1.0 (xAll)\apps_64\wputility_64" if I try to run it from there it doesn't work, but if I run it from "d:\temp" it works.

[kenshyura]

I think is because I use dirs with "!!!" chars and spaces and "(" chars.

[Aetherinox]

Curiosity.

Throw the bat file in a folder / path without spaces, and see if you can run it. Wondering if it's the spaces in the folder name. Something like C:\Test\file.bat

[kenshyura]

From C:\Test\wputility.bat works perfectly.
From C:!Test\wputility.bat doesn't work.

[kenshyura]

I don't why the "!" char doesn't show in the github panel.

[kenshyura]

From C:\test test\wputility.bat works perfectly.

And finally from C:(test)\wputility.bat doesn't work.

[Aetherinox]

Alright, so it appears to be just special chars, or at least a few of them. I'll dig around at the code and see if I can correct the path. That's why I originally set it up the way I did because if not, spaces will break the script as Windows sucks at handling anything with spaces unless you babysit it.

[kenshyura]

What I use to do is to "setlocal DisableDelayedExpansion" and only enable it when is strictly necessary, but I don't know much about it.

[Aetherinox]

Yup. I just created the path windows-update-killer\Software 2025!!WPI 2025 GUI 1.0 (xAll)\apps_64\wputility_64/wputility.bat and it's now closing mine too. At least I can duplicate this.

It's happening because of the top line

SETLOCAL    ENABLEDELAYEDEXPANSION

[kenshyura]

I made a few changes and I think it worked:
At the begining "SETLOCAL DISABLEDELAYEDEXPANSION"
and then in

:variables
setlocal ENABLEDELAYEDEXPANSION
set "dir_home=%~dp0"
set "dir_reg=%dir_home%registryBackup"

Note that I added quotes in the variables.

At least with that changes it run with specials chars in dir but I didn't test the whole script.

[Aetherinox]

Well if you want to test out some stuff, and make sure it works. You're welcome to create a PR and commit the changes to this repo. Then you'll pop up as a contributor.

I was going to do it in a bit after I finish committing another project I'm working on.

But what you did is pretty much where I was going with it too.

[kenshyura]

Allright, see what I can do.
Should I close this issue?

[Aetherinox]

It's fine for now. If you do commit, just add #9 at the end of the commit message. If not, I'll throw one up later. This will just remind me for now.