Adding support MV definer (#160)

Author: sharadgaur

parser/ast.go

@@ -1634,6 +1634,8 @@ type CreateMaterializedView struct {
 	SubQuery     *SubQuery
 	Populate     bool
 	Comment      *StringLiteral
+	Definer      *Ident
+	SQLSecurity  string
 }
 
 func (c *CreateMaterializedView) Pos() Pos {
@@ -1697,14 +1699,21 @@ func (c *CreateMaterializedView) String() string {
 	if c.HasEmpty {
 		builder.WriteString(" EMPTY")
 	}
+	if c.Definer != nil {
+		builder.WriteString(" DEFINER = ")
+		builder.WriteString(c.Definer.String())
+	}
+	if c.SQLSecurity != "" {
+		builder.WriteString(" SQL SECURITY ")
+		builder.WriteString(c.SQLSecurity)
+	}
 	if c.Populate {
-		builder.WriteString(" POPULATE ")
+		builder.WriteString(" POPULATE")
 	}
 	if c.SubQuery != nil {
 		builder.WriteString(" AS ")
 		builder.WriteString(c.SubQuery.String())
 	}
-
 	if c.Comment != nil {
 		builder.WriteString(" COMMENT ")
 		builder.WriteString(c.Comment.String())
@@ -1765,6 +1774,16 @@ func (c *CreateMaterializedView) Accept(visitor ASTVisitor) error {
 			return err
 		}
 	}
+	if c.Definer != nil {
+		if err := c.Definer.Accept(visitor); err != nil {
+			return err
+		}
+	}
+	if c.Comment != nil {
+		if err := c.Comment.Accept(visitor); err != nil {
+			return err
+		}
+	}
 	return visitor.VisitCreateMaterializedView(c)
 }
 

parser/keyword.go

@@ -234,6 +234,9 @@ const (
 	KeywordWindow       = "WINDOW"
 	KeywordWith         = "WITH"
 	KeywordYear         = "YEAR"
+	KeywordDefiner      = "DEFINER"
+	KeywordSQL          = "SQL"
+	KeywordSecurity     = "SECURITY"
 )
 
 var keywords = NewSet(
@@ -470,4 +473,7 @@ var keywords = NewSet(
 	KeywordWindow,
 	KeywordWith,
 	KeywordYear,
+	KeywordDefiner,
+	KeywordSQL,
+	KeywordSecurity,
 )

parser/parser_view.go

@@ -103,16 +103,44 @@ func (p *Parser) parseCreateMaterializedView(pos Pos) (*CreateMaterializedView,
 		}
 		createMaterializedView.Engine = engineExpr
 		createMaterializedView.StatementEnd = engineExpr.End()
-
-		if p.tryConsumeKeywords(KeywordPopulate) {
-			createMaterializedView.Populate = true
-			createMaterializedView.StatementEnd = p.Pos()
-		}
 	default:
 		return nil, fmt.Errorf("unexpected token: %q, expected TO or ENGINE", p.lastTokenKind())
 	}
 	createMaterializedView.HasEmpty = p.tryConsumeKeywords(KeywordEmpty)
 
+	// Parse DEFINER clause
+	if p.tryConsumeKeywords(KeywordDefiner) {
+		if err := p.expectTokenKind(TokenKindSingleEQ); err != nil {
+			return nil, err
+		}
+		definer, err := p.parseIdent()
+		if err != nil {
+			return nil, err
+		}
+		createMaterializedView.Definer = definer
+	}
+
+	// Parse SQL SECURITY clause
+	if p.tryConsumeKeywords(KeywordSQL, KeywordSecurity) {
+		if !p.matchOneOfKeywords(KeywordDefiner, KeywordNone) {
+			return nil, fmt.Errorf("expected DEFINER or NONE after SQL SECURITY, got %q", p.lastTokenKind())
+		}
+		createMaterializedView.SQLSecurity = p.last().String
+		_ = p.lexer.consumeToken()
+	}
+
+	// Check for POPULATE before AS SELECT - only valid with ENGINE and no Destination
+	if p.tryConsumeKeywords(KeywordPopulate) {
+		if createMaterializedView.Destination != nil {
+			return nil, fmt.Errorf("POPULATE is only allowed when using ENGINE, not with TO clause")
+		}
+		if createMaterializedView.Engine == nil {
+			return nil, fmt.Errorf("POPULATE requires ENGINE to be specified")
+		}
+		createMaterializedView.Populate = true
+		createMaterializedView.StatementEnd = p.Pos()
+	}
+
 	if p.tryConsumeKeywords(KeywordAs) {
 		subQuery, err := p.parseSubQuery(p.Pos())
 		if err != nil {

parser/testdata/ddl/create_materialized_view_with_definer.sql

@@ -0,0 +1,15 @@
+CREATE MATERIALIZED VIEW fresh_mv
+REFRESH EVERY 1 HOUR OFFSET 10 MINUTE APPEND TO events_export
+(
+    `timestamp` DateTime64(9),
+    `field_1` String,
+    `field_2` String,
+)
+DEFINER = default SQL SECURITY DEFINER
+AS (SELECT
+    timestamp,
+    field_1,
+    field_2,
+FROM event_table
+WHERE toStartOfHour(timestamp) = toStartOfHour(now() - toIntervalHour(1)))
+COMMENT 'Test comment'

parser/testdata/ddl/format/create_materialized_view_with_definer.sql

@@ -0,0 +1,20 @@
+-- Origin SQL:
+CREATE MATERIALIZED VIEW fresh_mv
+REFRESH EVERY 1 HOUR OFFSET 10 MINUTE APPEND TO events_export
+(
+    `timestamp` DateTime64(9),
+    `field_1` String,
+    `field_2` String,
+)
+DEFINER = default SQL SECURITY DEFINER
+AS (SELECT
+    timestamp,
+    field_1,
+    field_2,
+FROM event_table
+WHERE toStartOfHour(timestamp) = toStartOfHour(now() - toIntervalHour(1)))
+COMMENT 'Test comment'
+
+
+-- Format SQL:
+CREATE MATERIALIZED VIEW fresh_mv REFRESH EVERY 1 HOUR OFFSET 10 MINUTE APPEND TO events_export (`timestamp` DateTime64(9), `field_1` String, `field_2` String) DEFINER = default SQL SECURITY DEFINER AS (SELECT timestamp, field_1, field_2, FROM AS event_table WHERE toStartOfHour(timestamp) = toStartOfHour(now() - toIntervalHour(1))) COMMENT 'Test comment';

parser/testdata/ddl/format/create_materialized_view_with_empty_table_schema.sql

@@ -16,4 +16,4 @@ from
 where rn = 1;
 
 -- Format SQL:
-CREATE MATERIALIZED VIEW test.t0 ON CLUSTER default_cluster ENGINE = ReplicatedAggregatingMergeTree('/clickhouse/{layer}-{shard}/test/t0', '{replica}') PARTITION BY toYYYYMM(f0) ORDER BY (f0) POPULATE  AS SELECT f0, f1, f2, coalesce(f0, f1) AS f333 FROM (SELECT f0, f1, f2, ROW_NUMBER() OVER ( PARTITION BY f0 ORDER BY coalesce(f1, f2)) AS rn FROM test.t WHERE f3 IN ('foo', 'bar', 'test') AND env = 'test') AS tmp WHERE rn = 1;
+CREATE MATERIALIZED VIEW test.t0 ON CLUSTER default_cluster ENGINE = ReplicatedAggregatingMergeTree('/clickhouse/{layer}-{shard}/test/t0', '{replica}') PARTITION BY toYYYYMM(f0) ORDER BY (f0) POPULATE AS SELECT f0, f1, f2, coalesce(f0, f1) AS f333 FROM (SELECT f0, f1, f2, ROW_NUMBER() OVER ( PARTITION BY f0 ORDER BY coalesce(f1, f2)) AS rn FROM test.t WHERE f3 IN ('foo', 'bar', 'test') AND env = 'test') AS tmp WHERE rn = 1;

parser/testdata/ddl/output/bug_001.sql.golden.json

@@ -571,6 +571,8 @@
       }
     },
     "Populate": false,
-    "Comment": null
+    "Comment": null,
+    "Definer": null,
+    "SQLSecurity": ""
   }
 ]

parser/testdata/ddl/output/create_materialized_view_basic.sql.golden.json

@@ -542,6 +542,8 @@
       "LiteralPos": 548,
       "LiteralEnd": 565,
       "Literal": "Comment for table"
-    }
+    },
+    "Definer": null,
+    "SQLSecurity": ""
   }
 ]