Remove an extra leading space when formatting the WINDOW FUNCTION (#174)

Author: git-hulk

parser/ast.go

@@ -5790,20 +5790,20 @@ func (w *WindowExpr) End() Pos {
 }
 
 func (w *WindowExpr) String() string {
-	var builder strings.Builder
-	builder.WriteByte('(')
+	parts := make([]string, 0)
 	if w.PartitionBy != nil {
-		builder.WriteString(" ")
-		builder.WriteString(w.PartitionBy.String())
+		parts = append(parts, w.PartitionBy.String())
 	}
 	if w.OrderBy != nil {
-		builder.WriteString(" ")
-		builder.WriteString(w.OrderBy.String())
+		parts = append(parts, w.OrderBy.String())
 	}
 	if w.Frame != nil {
-		builder.WriteString(" ")
-		builder.WriteString(w.Frame.String())
+		parts = append(parts, w.Frame.String())
 	}
+
+	var builder strings.Builder
+	builder.WriteByte('(')
+	builder.WriteString(strings.Join(parts, " "))
 	builder.WriteByte(')')
 	return builder.String()
 }

parser/testdata/ddl/format/create_materialized_view_with_empty_table_schema.sql

@@ -16,4 +16,4 @@ from
 where rn = 1;
 
 -- Format SQL:
-CREATE MATERIALIZED VIEW test.t0 ON CLUSTER default_cluster ENGINE = ReplicatedAggregatingMergeTree('/clickhouse/{layer}-{shard}/test/t0', '{replica}') PARTITION BY toYYYYMM(f0) ORDER BY (f0) POPULATE AS SELECT f0, f1, f2, coalesce(f0, f1) AS f333 FROM (SELECT f0, f1, f2, ROW_NUMBER() OVER ( PARTITION BY f0 ORDER BY coalesce(f1, f2)) AS rn FROM test.t WHERE f3 IN ('foo', 'bar', 'test') AND env = 'test') AS tmp WHERE rn = 1;
+CREATE MATERIALIZED VIEW test.t0 ON CLUSTER default_cluster ENGINE = ReplicatedAggregatingMergeTree('/clickhouse/{layer}-{shard}/test/t0', '{replica}') PARTITION BY toYYYYMM(f0) ORDER BY (f0) POPULATE AS SELECT f0, f1, f2, coalesce(f0, f1) AS f333 FROM (SELECT f0, f1, f2, ROW_NUMBER() OVER (PARTITION BY f0 ORDER BY coalesce(f1, f2)) AS rn FROM test.t WHERE f3 IN ('foo', 'bar', 'test') AND env = 'test') AS tmp WHERE rn = 1;

parser/testdata/query/format/select_simple.sql

@@ -12,4 +12,4 @@ GROUP BY f0,   f1
 Limit 100, 10 By f0;
 
 -- Format SQL:
-SELECT f0, coalesce(f1, f2) AS f3, row_number() OVER ( PARTITION BY f0 ORDER BY f1 ASC) AS rn FROM test.events_local WHERE (f0 IN ('foo', 'bar', 'test')) AND (f1 = 'testing') AND (f2 NOT LIKE 'testing2') AND f3 NOT IN ('a', 'b', 'c') GROUP BY f0, f1 LIMIT 10 OFFSET 100 BY f0;
+SELECT f0, coalesce(f1, f2) AS f3, row_number() OVER (PARTITION BY f0 ORDER BY f1 ASC) AS rn FROM test.events_local WHERE (f0 IN ('foo', 'bar', 'test')) AND (f1 = 'testing') AND (f2 NOT LIKE 'testing2') AND f3 NOT IN ('a', 'b', 'c') GROUP BY f0, f1 LIMIT 10 OFFSET 100 BY f0;

parser/testdata/query/format/select_with_window_function.sql

@@ -14,4 +14,4 @@ WINDOW w AS (PARTITION BY aggregation_target
     ORDER BY timestamp DESC ROWS BETWEEN UNBOUNDED PRECEDING AND 0 PRECEDING);
 
 -- Format SQL:
-SELECT aggregation_target AS aggregation_target, timestamp AS timestamp, step_0 AS step_0, latest_0 AS latest_0, step_1 AS step_1, latest_1 AS latest_1, step_2 AS step_2, min(latest_2) OVER ( PARTITION BY aggregation_target ORDER BY timestamp DESC ROWS  BETWEEN  UNBOUNDED PRECEDING AND  0 PRECEDING) AS latest_2, min(latest_1) OVER w AS latest_1 FROM t0 WINDOW w AS ( PARTITION BY aggregation_target ORDER BY timestamp DESC ROWS  BETWEEN  UNBOUNDED PRECEDING AND  0 PRECEDING);
+SELECT aggregation_target AS aggregation_target, timestamp AS timestamp, step_0 AS step_0, latest_0 AS latest_0, step_1 AS step_1, latest_1 AS latest_1, step_2 AS step_2, min(latest_2) OVER (PARTITION BY aggregation_target ORDER BY timestamp DESC ROWS  BETWEEN  UNBOUNDED PRECEDING AND  0 PRECEDING) AS latest_2, min(latest_1) OVER w AS latest_1 FROM t0 WINDOW w AS (PARTITION BY aggregation_target ORDER BY timestamp DESC ROWS  BETWEEN  UNBOUNDED PRECEDING AND  0 PRECEDING);