Fix missing type level in codec constraint (#82)

Author: laojianzi

parser/ast.go

@@ -3276,6 +3276,7 @@ type CompressionCodec struct {
 	CodecPos      Pos
 	RightParenPos Pos
 	Type          *Ident
+	TypeLevel     *NumberLiteral
 	Name          *Ident
 	Level         *NumberLiteral // compression level
 }
@@ -3293,6 +3294,11 @@ func (c *CompressionCodec) String(level int) string {
 	builder.WriteString("CODEC(")
 	if c.Type != nil {
 		builder.WriteString(c.Type.String(level))
+		if c.TypeLevel != nil {
+			builder.WriteByte('(')
+			builder.WriteString(c.TypeLevel.String(level))
+			builder.WriteByte(')')
+		}
 		builder.WriteByte(',')
 		builder.WriteByte(' ')
 	}
@@ -3309,6 +3315,14 @@ func (c *CompressionCodec) String(level int) string {
 func (c *CompressionCodec) Accept(visitor ASTVisitor) error {
 	visitor.enter(c)
 	defer visitor.leave(c)
+	if err := c.Type.Accept(visitor); err != nil {
+		return err
+	}
+	if c.TypeLevel != nil {
+		if err := c.TypeLevel.Accept(visitor); err != nil {
+			return err
+		}
+	}
 	if err := c.Name.Accept(visitor); err != nil {
 		return err
 	}

parser/parser_column.go

@@ -803,10 +803,12 @@ func (p *Parser) tryParseCompressionCodecs(pos Pos) (*CompressionCodec, error) {
 	}
 	// parse DELTA if  CODEC(Delta, ZSTD(1)) or CODEC(Delta(9), ZSTD(1))
 	var codecType *Ident
+	var typeLevel *NumberLiteral
 	if strings.ToUpper(name.Name) == "DELTA" {
 		codecType = name
 		// try parse delta level
-		if _, err := p.tryParseCompressionLevel(p.Pos()); err != nil {
+		typeLevel, err = p.tryParseCompressionLevel(p.Pos())
+		if err != nil {
 			return nil, err
 		}
 		// consume comma
@@ -838,6 +840,7 @@ func (p *Parser) tryParseCompressionCodecs(pos Pos) (*CompressionCodec, error) {
 		CodecPos:      pos,
 		RightParenPos: rightParenPos,
 		Type:          codecType,
+		TypeLevel:     typeLevel,
 		Name:          name,
 		Level:         level,
 	}, nil

parser/testdata/ddl/format/create_table_with_codec_delta.sql

@@ -19,7 +19,7 @@ CREATE TABLE IF NOT EXISTS test_local
 (
   `id` UInt64 CODEC(Delta, ZSTD(1)),
   `api_id` UInt64 CODEC(ZSTD(1)),
-  `app_id` UInt64 CODEC(Delta, ZSTD(1)),
+  `app_id` UInt64 CODEC(Delta(9), ZSTD(1)),
   `timestamp` DateTime64(9) CODEC(ZSTD(1)),
   INDEX timestamp_index(timestamp) TYPE minmax GRANULARITY 4
 )

parser/testdata/ddl/output/create_table_basic.sql.golden.json

@@ -78,6 +78,7 @@
             "CodecPos": 198,
             "RightParenPos": 212,
             "Type": null,
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,

parser/testdata/ddl/output/create_table_with_codec_delta.sql.golden.json

@@ -50,6 +50,7 @@
               "NamePos": 59,
               "NameEnd": 64
             },
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,
@@ -94,6 +95,7 @@
             "CodecPos": 93,
             "RightParenPos": 107,
             "Type": null,
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,
@@ -143,6 +145,12 @@
               "NamePos": 132,
               "NameEnd": 137
             },
+            "TypeLevel": {
+              "NumPos": 137,
+              "NumEnd": 139,
+              "Literal": "9",
+              "Base": 10
+            },
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,
@@ -197,6 +205,7 @@
             "CodecPos": 179,
             "RightParenPos": 193,
             "Type": null,
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,

parser/testdata/ddl/output/create_table_with_index.sql.golden.json

@@ -50,6 +50,7 @@
               "NamePos": 59,
               "NameEnd": 64
             },
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,
@@ -94,6 +95,7 @@
             "CodecPos": 93,
             "RightParenPos": 107,
             "Type": null,
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,
@@ -178,6 +180,7 @@
             "CodecPos": 148,
             "RightParenPos": 162,
             "Type": null,
+            "TypeLevel": null,
             "Name": {
               "Name": "ZSTD",
               "QuoteType": 1,