test: assert protocol mismatch fails without retries

Author: seth-ekc

swe_af/agent_ai/providers/claude/client.py

@@ -62,6 +62,9 @@
     }
 )
 
+# Keep in sync with dependency pins in pyproject/requirements.
+_STABLE_SDK_VERSION = "0.1.20"
+
 DEFAULT_TOOLS: list[str] = [
     Tool.READ,
     Tool.WRITE,
@@ -76,8 +79,6 @@
 
 def _is_transient(error: str) -> bool:
     if _is_sdk_protocol_error(error):
-        # Protocol/schema mismatch between SDK and upstream event stream
-        # is deterministic and should fail fast with guidance.
         return False
     low = error.lower()
     return any(p in low for p in _TRANSIENT_PATTERNS)
@@ -101,7 +102,7 @@ def _build_sdk_protocol_error_message(raw_error: str, *, sdk_version: str | None
         f"{raw_error}. "
         f"Detected claude-agent-sdk version={version}. "
         "This is a known stream compatibility failure in some SDK versions. "
-        "Use claude-agent-sdk==0.1.20 for SWE-AF stability."
+        f"Use claude-agent-sdk=={_STABLE_SDK_VERSION} for SWE-AF stability."
     )
 
 
@@ -420,7 +421,7 @@ async def _run_with_retries(
 
                 last_exc = e
                 _captured_stderr = "\n".join(stderr_lines[-50:]) if stderr_lines else ""
-                if attempt < effective_retries and _is_transient(str(e)):
+                if attempt < effective_retries and _is_transient(raw_error):
                     if log_fh:
                         _write_log(
                             log_fh,

tests/test_claude_provider_compat.py

@@ -1,6 +1,9 @@
 import unittest
+from unittest.mock import AsyncMock
 
+from claude_agent_sdk import ClaudeAgentOptions
 from swe_af.agent_ai.providers.claude.client import (
+    ClaudeProviderClient,
     _build_sdk_protocol_error_message,
     _is_sdk_protocol_error,
     _is_transient,
@@ -22,6 +25,36 @@ def test_protocol_error_message_contains_sdk_guidance(self) -> None:
         self.assertIn("version=0.1.39", msg)
         self.assertIn("claude-agent-sdk==0.1.20", msg)
 
+    def test_protocol_error_fails_fast_without_retries(self) -> None:
+        err = "Unknown message type: rate_limit_event"
+        client = ClaudeProviderClient()
+        client._execute = AsyncMock(side_effect=RuntimeError(err))
+        options = ClaudeAgentOptions(model="sonnet", cwd=".", max_turns=1)
+
+        async def _run() -> None:
+            await client._run_with_retries(
+                prompt="test",
+                final_prompt="test",
+                options=options,
+                output_schema=None,
+                output_path=None,
+                effective_cwd=".",
+                effective_model="sonnet",
+                effective_env={},
+                effective_perm=None,
+                effective_retries=3,
+                temp_files=[],
+                stderr_lines=[],
+            )
+
+        with self.assertRaises(RuntimeError) as ctx:
+            import asyncio
+
+            asyncio.run(_run())
+
+        self.assertIn("claude-agent-sdk==0.1.20", str(ctx.exception))
+        self.assertEqual(client._execute.await_count, 1)
+
 
 if __name__ == "__main__":
     unittest.main()