test(record_action): replace assert len(mock_req.request_history) == N checks with specific request filtering

Replaced request count assertions with specific request filtering
Added helper to find relevant requests using URL patterns
Made assertions more focused on the actual action recording
functionality
Maintained all existing functionality checks while removing dependency
on request count

Signed-off-by: Teo <teocns@gmail.com>

Author: teocns

tests/unit/test_record_action.py

@@ -25,10 +25,13 @@ def add_two(x, y):
         add_two(3, 4)
         time.sleep(0.1)
 
-        # 3 requests: check_for_updates, start_session, record_action
-        assert len(mock_req.request_history) == 3
-        assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
-        request_json = mock_req.last_request.json()
+        # Find the record_action request
+        action_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
+        assert len(action_requests) > 0
+        last_action_request = action_requests[-1]
+
+        assert last_action_request.headers["X-Agentops-Api-Key"] == self.api_key
+        request_json = last_action_request.json()
         assert request_json["events"][0]["action_type"] == self.event_type
         assert request_json["events"][0]["params"] == {"x": 3, "y": 4}
         assert request_json["events"][0]["returns"] == 7
@@ -46,10 +49,13 @@ def add_two(x, y):
         add_two(3, 4)
         time.sleep(0.1)
 
-        # 3 requests: check_for_updates, start_session, record_action
-        assert len(mock_req.request_history) == 3
-        assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
-        request_json = mock_req.last_request.json()
+        # Find the record_action request
+        action_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
+        assert len(action_requests) > 0
+        last_action_request = action_requests[-1]
+
+        assert last_action_request.headers["X-Agentops-Api-Key"] == self.api_key
+        request_json = last_action_request.json()
         assert request_json["events"][0]["action_type"] == "add_two"
         assert request_json["events"][0]["params"] == {"x": 3, "y": 4}
         assert request_json["events"][0]["returns"] == 7
@@ -70,10 +76,13 @@ def add_three(x, y, z=3):
 
         time.sleep(1.5)
 
-        # 3 requests: check_for_updates, start_session, record_action
-        assert len(mock_req.request_history) == 3
-        assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
-        request_json = mock_req.last_request.json()
+        # Find the record_action request
+        action_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
+        assert len(action_requests) > 0
+        last_action_request = action_requests[-1]
+
+        assert last_action_request.headers["X-Agentops-Api-Key"] == self.api_key
+        request_json = last_action_request.json()
 
         assert request_json["events"][1]["action_type"] == self.event_type
         assert request_json["events"][1]["params"] == {"x": 1, "y": 2, "z": 4}
@@ -100,10 +109,14 @@ async def async_add(x, y):
 
         # Assert
         assert result == 7
-        # Assert
-        assert len(mock_req.request_history) == 3
-        assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
-        request_json = mock_req.last_request.json()
+
+        # Find the record_action request
+        action_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
+        assert len(action_requests) > 0
+        last_action_request = action_requests[-1]
+
+        assert last_action_request.headers["X-Agentops-Api-Key"] == self.api_key
+        request_json = last_action_request.json()
         assert request_json["events"][0]["action_type"] == self.event_type
         assert request_json["events"][0]["params"] == {"x": 3, "y": 4}
         assert request_json["events"][0]["returns"] == 7
@@ -132,31 +145,29 @@ def add_three(x, y, z=3):
         add_three(1, 2, 3, session=session_2)
         time.sleep(0.1)
 
-        assert len(mock_req.request_history) == 5
+        # Find action requests
+        action_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
+        assert len(action_requests) >= 2  # Should have at least 2 action requests
 
-        request_json = mock_req.last_request.json()
-        assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
-        assert (
-            mock_req.last_request.headers["Authorization"]
-            == f"Bearer {mock_req.session_jwts[str(session_2.session_id)]}"
-        )
+        # Verify session_2's request (last request)
+        last_request = action_requests[-1]
+        assert last_request.headers["X-Agentops-Api-Key"] == self.api_key
+        assert last_request.headers["Authorization"] == f"Bearer {mock_req.session_jwts[str(session_2.session_id)]}"
+        request_json = last_request.json()
         assert request_json["events"][0]["action_type"] == self.event_type
         assert request_json["events"][0]["params"] == {"x": 1, "y": 2, "z": 3}
         assert request_json["events"][0]["returns"] == 6
 
-        second_last_request_json = mock_req.request_history[-2].json()
-        assert mock_req.request_history[-2].headers["X-Agentops-Api-Key"] == self.api_key
+        # Verify session_1's request (second to last request)
+        second_last_request = action_requests[-2]
+        assert second_last_request.headers["X-Agentops-Api-Key"] == self.api_key
         assert (
-            mock_req.request_history[-2].headers["Authorization"]
-            == f"Bearer {mock_req.session_jwts[str(session_1.session_id)]}"
+            second_last_request.headers["Authorization"] == f"Bearer {mock_req.session_jwts[str(session_1.session_id)]}"
         )
-        assert second_last_request_json["events"][0]["action_type"] == self.event_type
-        assert second_last_request_json["events"][0]["params"] == {
-            "x": 1,
-            "y": 2,
-            "z": 3,
-        }
-        assert second_last_request_json["events"][0]["returns"] == 6
+        request_json = second_last_request.json()
+        assert request_json["events"][0]["action_type"] == self.event_type
+        assert request_json["events"][0]["params"] == {"x": 1, "y": 2, "z": 3}
+        assert request_json["events"][0]["returns"] == 6
 
         session_1.end_session(end_state="Success")
         session_2.end_session(end_state="Success")