Skip to content

Commit ec1978c

Browse files
committed
Squash merge teocns/improve-session-tests-assertions into logcap
Signed-off-by: Teo <[email protected]>
1 parent 76551b6 commit ec1978c

File tree

1 file changed

+24
-22
lines changed

1 file changed

+24
-22
lines changed

tests/unit/test_record_tool.py

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,14 @@ async def async_add(x, y):
108108

109109
# Assert
110110
assert result == 7
111-
# Assert
112-
assert len(mock_req.request_history) == 3
113-
assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
114-
request_json = mock_req.last_request.json()
111+
112+
# Find the record_tool request
113+
tool_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
114+
assert len(tool_requests) > 0
115+
last_tool_request = tool_requests[-1]
116+
117+
assert last_tool_request.headers["X-Agentops-Api-Key"] == self.api_key
118+
request_json = last_tool_request.json()
115119
assert request_json["events"][0]["name"] == self.tool_name
116120
assert request_json["events"][0]["params"] == {"x": 3, "y": 4}
117121
assert request_json["events"][0]["returns"] == 7
@@ -186,31 +190,29 @@ async def async_add(x, y):
186190
await async_add(1, 2, session=session_2)
187191
time.sleep(0.1)
188192

189-
# Assert
190-
assert len(mock_req.request_history) == 5
193+
# Find tool requests
194+
tool_requests = [r for r in mock_req.request_history if "/v2/create_events" in r.url]
195+
assert len(tool_requests) >= 2 # Should have at least 2 tool requests
191196

192-
request_json = mock_req.last_request.json()
193-
assert mock_req.last_request.headers["X-Agentops-Api-Key"] == self.api_key
194-
assert (
195-
mock_req.last_request.headers["Authorization"]
196-
== f"Bearer {mock_req.session_jwts[str(session_2.session_id)]}"
197-
)
197+
# Verify session_2's request (last request)
198+
last_request = tool_requests[-1]
199+
assert last_request.headers["X-Agentops-Api-Key"] == self.api_key
200+
assert last_request.headers["Authorization"] == f"Bearer {mock_req.session_jwts[str(session_2.session_id)]}"
201+
request_json = last_request.json()
198202
assert request_json["events"][0]["name"] == self.tool_name
199203
assert request_json["events"][0]["params"] == {"x": 1, "y": 2}
200204
assert request_json["events"][0]["returns"] == 3
201205

202-
second_last_request_json = mock_req.request_history[-2].json()
203-
assert mock_req.request_history[-2].headers["X-Agentops-Api-Key"] == self.api_key
206+
# Verify session_1's request (second to last request)
207+
second_last_request = tool_requests[-2]
208+
assert second_last_request.headers["X-Agentops-Api-Key"] == self.api_key
204209
assert (
205-
mock_req.request_history[-2].headers["Authorization"]
206-
== f"Bearer {mock_req.session_jwts[str(session_1.session_id)]}"
210+
second_last_request.headers["Authorization"] == f"Bearer {mock_req.session_jwts[str(session_1.session_id)]}"
207211
)
208-
assert second_last_request_json["events"][0]["name"] == self.tool_name
209-
assert second_last_request_json["events"][0]["params"] == {
210-
"x": 1,
211-
"y": 2,
212-
}
213-
assert second_last_request_json["events"][0]["returns"] == 3
212+
request_json = second_last_request.json()
213+
assert request_json["events"][0]["name"] == self.tool_name
214+
assert request_json["events"][0]["params"] == {"x": 1, "y": 2}
215+
assert request_json["events"][0]["returns"] == 3
214216

215217
session_1.end_session(end_state="Success")
216218
session_2.end_session(end_state="Success")

0 commit comments

Comments
 (0)