-
Notifications
You must be signed in to change notification settings - Fork 509
Refactor CrewAI instrumentation to enhance span attribute management #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Member
Author
|
Updated Span: |
…pdate version to 0.36.0. Removed third-party dependencies and improved error handling in agent and task processing.
areibman
approved these changes
Apr 23, 2025
Contributor
areibman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
I've organized the data into clear categories (crew, agent, task, etc.) instead of having everything mixed together. This makes it much easier to find specific information.
The data is now structured in a way that's much easier for frontend applications to work with. No more parsing complex JSON strings - everything is neatly organized and accessible.
Here is a spanAttribute for reference:
@areibman Please review this and LMK if any changes are required
I tried serializing but it resulted in RecursionError in JSON Serialization: I was encountering a "maximum recursion depth exceeded" error when the CrewAI instrumentation tried to serialize complex objects with circular references or deeply nested structures.
Fields like tools should be treated as text data rather than parsed JSON
OR
For fields containing Python objects, use regex to extract useful information (I might be incorrect with the regex):