Skip to content

Commit b7a2acb

Browse files
mmabroukclaude
andcommitted
fix(api): correct testsets router to use VIEW_TESTSETS for read operations
The testsets router was incorrectly using EDIT_EVALUATORS permission for all operations including read-only endpoints. This prevented viewers from accessing testsets, testset variants, and testset revisions. Fixed the following endpoints to use VIEW_TESTSETS instead: - fetch_testset - query_testsets - fetch_testset_variant - query_testset_variants - retrieve_testset_revision - fetch_testset_revision - query_testset_revisions - log_testset_revisions Write operations (create, edit, archive, commit) continue to use EDIT_EVALUATORS which correctly prevents viewers from modifying content. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent 2c83a79 commit b7a2acb

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

api/oss/src/apis/fastapi/testsets/router.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ async def fetch_testset(
555555
if not await check_action_access( # type: ignore
556556
user_uid=request.state.user_id,
557557
project_id=request.state.project_id,
558-
permission=Permission.EDIT_EVALUATORS, # type: ignore
558+
permission=Permission.VIEW_TESTSETS, # type: ignore
559559
):
560560
raise FORBIDDEN_EXCEPTION # type: ignore
561561

@@ -671,7 +671,7 @@ async def query_testsets(
671671
if not await check_action_access( # type: ignore
672672
user_uid=request.state.user_id,
673673
project_id=request.state.project_id,
674-
permission=Permission.EDIT_EVALUATORS, # type: ignore
674+
permission=Permission.VIEW_TESTSETS, # type: ignore
675675
):
676676
raise FORBIDDEN_EXCEPTION # type: ignore
677677

@@ -738,7 +738,7 @@ async def fetch_testset_variant(
738738
if not await check_action_access( # type: ignore
739739
user_uid=request.state.user_id,
740740
project_id=request.state.project_id,
741-
permission=Permission.EDIT_EVALUATORS, # type: ignore
741+
permission=Permission.VIEW_TESTSETS, # type: ignore
742742
):
743743
raise FORBIDDEN_EXCEPTION # type: ignore
744744

@@ -854,7 +854,7 @@ async def query_testset_variants(
854854
if not await check_action_access( # type: ignore
855855
user_uid=request.state.user_id,
856856
project_id=request.state.project_id,
857-
permission=Permission.EDIT_EVALUATORS, # type: ignore
857+
permission=Permission.VIEW_TESTSETS, # type: ignore
858858
):
859859
raise FORBIDDEN_EXCEPTION # type: ignore
860860

@@ -890,7 +890,7 @@ async def retrieve_testset_revision(
890890
if not await check_action_access( # type: ignore
891891
user_uid=request.state.user_id,
892892
project_id=request.state.project_id,
893-
permission=Permission.EDIT_EVALUATORS, # type: ignore
893+
permission=Permission.VIEW_TESTSETS, # type: ignore
894894
):
895895
raise FORBIDDEN_EXCEPTION # type: ignore
896896

@@ -977,7 +977,7 @@ async def fetch_testset_revision(
977977
if not await check_action_access( # type: ignore
978978
user_uid=request.state.user_id,
979979
project_id=request.state.project_id,
980-
permission=Permission.EDIT_EVALUATORS, # type: ignore
980+
permission=Permission.VIEW_TESTSETS, # type: ignore
981981
):
982982
raise FORBIDDEN_EXCEPTION # type: ignore
983983

@@ -1183,7 +1183,7 @@ async def query_testset_revisions(
11831183
if not await check_action_access( # type: ignore
11841184
user_uid=request.state.user_id,
11851185
project_id=request.state.project_id,
1186-
permission=Permission.EDIT_EVALUATORS, # type: ignore
1186+
permission=Permission.VIEW_TESTSETS, # type: ignore
11871187
):
11881188
raise FORBIDDEN_EXCEPTION # type: ignore
11891189

@@ -1260,7 +1260,7 @@ async def log_testset_revisions(
12601260
if not await check_action_access( # type: ignore
12611261
user_uid=request.state.user_id,
12621262
project_id=request.state.project_id,
1263-
permission=Permission.EDIT_EVALUATORS, # type: ignore
1263+
permission=Permission.VIEW_TESTSETS, # type: ignore
12641264
):
12651265
raise FORBIDDEN_EXCEPTION # type: ignore
12661266

0 commit comments

Comments
 (0)