Skip to content

Commit 5ea97da

Browse files
committed
chore:Rename RegionArea to DomainArea
1 parent 5fa4f58 commit 5ea97da

File tree

12 files changed

+47
-46
lines changed

12 files changed

+47
-46
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<img alt="Maven Central Version" src="https://img.shields.io/maven-central/v/io.agora/agora-rest-client-core?colorB=brightgreen">
55
<img alt="GitHub License" src="https://img.shields.io/github/license/AgoraIO-Community/agora-rest-client-java">
66
<a href="https://github.com/AgoraIO-Community/agora-rest-client-java/actions/workflows/maven.yml"><img alt="Java CI with Maven" src="https://github.com/AgoraIO-Community/agora-rest-client-java/actions/workflows/maven.yml/badge.svg"></a>
7+
<a href="https://github.com/AgoraIO-Community/agora-rest-client-java/actions/workflows/gitee-sync.yml"><img alt="gitee-sync" src="https://github.com/AgoraIO-Community/agora-rest-client-java/actions/workflows/gitee-sync.yml/badge.svg?branch=main"></a>
78
<img alt="GitHub" src="https://img.shields.io/github/v/release/AgoraIO-Community/agora-rest-client-java">
89
<img alt="GitHub Issues or Pull Requests" src="https://img.shields.io/github/issues-pr/AgoraIO-Community/agora-rest-client-java">
910
</p>
@@ -56,7 +57,7 @@ import io.agora.rest.AgoraException;
5657
import io.agora.rest.core.AgoraConfig;
5758
import io.agora.rest.core.BasicAuthCredential;
5859
import io.agora.rest.core.Credential;
59-
import io.agora.rest.core.RegionArea;
60+
import io.agora.rest.core.DomainArea;
6061
import io.agora.rest.services.cloudrecording.api.req.StartResourceReq;
6162
import io.agora.rest.services.cloudrecording.api.res.AcquireResourceRes;
6263
import io.agora.rest.services.cloudrecording.api.res.StartResourceRes;
@@ -101,9 +102,9 @@ public class Main {
101102
.appId(appId)
102103
.credential(credential)
103104
// Specify the region where the server is located.
104-
// Optional values are CN, NA, EU, AP, and the client will automatically
105+
// Optional values are CN, US, EU, AP, and the client will automatically
105106
// switch to use the best domain name according to the configured region
106-
.regionArea(RegionArea.CNRegionArea)
107+
.domainArea(DomainArea.)
107108
.build();
108109

109110
// Initialize CloudRecordingClient

agora-rest-client-core/src/main/java/io/agora/rest/core/AgoraConfig.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ public class AgoraConfig {
55

66
private final Credential credential;
77

8-
private final RegionArea regionArea;
8+
private final DomainArea domainArea;
99

1010
private final HttpProperty httpProperty;
1111

1212
private AgoraConfig(Builder builder) {
1313
this.appId = builder.appId;
1414
this.credential = builder.credential;
15-
this.regionArea = builder.regionArea;
15+
this.domainArea = builder.domainArea;
1616
this.httpProperty = builder.httpProperty;
1717
}
1818

@@ -28,8 +28,8 @@ public Credential getCredential() {
2828
return credential;
2929
}
3030

31-
public RegionArea getRegionArea() {
32-
return regionArea;
31+
public DomainArea getDomainArea() {
32+
return domainArea;
3333
}
3434

3535
public HttpProperty getHttpProperty() {
@@ -41,7 +41,7 @@ public String toString() {
4141
return "AgoraConfig{" +
4242
"appId='" + appId + '\'' +
4343
", credential=" + credential +
44-
", regionArea=" + regionArea +
44+
", domainArea=" + domainArea +
4545
", httpProperty=" + httpProperty +
4646
'}';
4747
}
@@ -52,7 +52,7 @@ public static class Builder {
5252

5353
private Credential credential;
5454

55-
private RegionArea regionArea;
55+
private DomainArea domainArea;
5656

5757
private HttpProperty httpProperty;
5858

@@ -69,8 +69,8 @@ public Builder credential(Credential credential) {
6969
return this;
7070
}
7171

72-
public Builder regionArea(RegionArea regionArea) {
73-
this.regionArea = regionArea;
72+
public Builder domainArea(DomainArea domainArea) {
73+
this.domainArea = domainArea;
7474
return this;
7575
}
7676

agora-rest-client-core/src/main/java/io/agora/rest/core/DefaultContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class DefaultContext implements Context {
2727
public DefaultContext(AgoraConfig agoraConfig) {
2828
this.agoraConfig = agoraConfig;
2929
this.httpClient = HttpClientFactory.createHttpClient(agoraConfig);
30-
this.domainPool = new DomainPool(agoraConfig.getRegionArea());
30+
this.domainPool = new DomainPool(agoraConfig.getDomainArea());
3131
this.codec = new JsonCodec();
3232
}
3333

agora-rest-client-core/src/main/java/io/agora/rest/core/RegionArea.java renamed to agora-rest-client-core/src/main/java/io/agora/rest/core/DomainArea.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,45 +4,45 @@
44
import java.util.Collections;
55
import java.util.List;
66

7-
public enum RegionArea {
7+
public enum DomainArea {
88
/**
9-
* Unknown region area
9+
* Unknown domain area
1010
*/
11-
UnkonwnRegionArea(Collections.emptyList(), Collections.emptyList()),
11+
Unknown(Collections.emptyList(), Collections.emptyList()),
1212

1313
/**
14-
* US region area
14+
* US domain area
1515
*/
16-
USRegionArea(
16+
US(
1717
Arrays.asList("api-us-west-1", "api-us-east-1"),
1818
Arrays.asList("agora.io", "sd-rtn.com")),
1919

2020
/**
21-
* EU region area
21+
* EU domain area
2222
*/
23-
EURegionArea(
23+
EU(
2424
Arrays.asList("api-eu-west-1", "api-eu-central-1"),
2525
Arrays.asList("agora.io", "sd-rtn.com")),
2626

2727
/**
28-
* AP region area
28+
* AP domain area
2929
*/
30-
APRegionArea(
30+
AP(
3131
Arrays.asList("api-ap-southeast-1", "api-ap-northeast-1"),
3232
Arrays.asList("agora.io", "sd-rtn.com")),
3333

3434
/**
35-
* CN region area
35+
* CN domain area
3636
*/
37-
CNRegionArea(
37+
CN(
3838
Arrays.asList("api-cn-east-1", "api-cn-north-1"),
3939
Arrays.asList("sd-rtn.com", "agora.io"));
4040

4141
private final List<String> regionDomainPrefixes;
4242

4343
private final List<String> majorDomainSuffixes;
4444

45-
RegionArea(List<String> regionDomainPrefixes, List<String> majorDomainSuffixes) {
45+
DomainArea(List<String> regionDomainPrefixes, List<String> majorDomainSuffixes) {
4646
this.regionDomainPrefixes = Collections.unmodifiableList(regionDomainPrefixes);
4747
this.majorDomainSuffixes = Collections.unmodifiableList(majorDomainSuffixes);
4848
}

agora-rest-client-core/src/main/java/io/agora/rest/core/DomainPool.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public class DomainPool {
3030

3131
private final Logger logger = LoggerFactory.getLogger(DomainPool.class);
3232

33-
public DomainPool(RegionArea domainArea) {
34-
if (domainArea == null || domainArea == RegionArea.UnkonwnRegionArea) {
33+
public DomainPool(DomainArea domainArea) {
34+
if (domainArea == null || domainArea == DomainArea.Unknown) {
3535
throw new AgoraInvalidArgumentException("invalid domain area");
3636
}
3737

agora-rest-client-core/src/main/java/io/agora/rest/services/cloudrecording/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
.appId(appId)
5454
.credential(credential)
5555
// Specify the region where the server is located.
56-
// Optional values are CN, NA, EU, AP, and the client will automatically
56+
// Optional values are CN, US, EU, AP, and the client will automatically
5757
// switch to use the best domain name according to the configured region
58-
.regionArea(region)
58+
.domainArea(DomainArea.CN)
5959
.build();
6060

6161
// Initialize CloudRecordingClient

agora-rest-client-core/src/test/java/io/agora/rest/core/DomainDNSResolverTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ public void testDomainDNSResolver() {
1818
assertNotNull(resolver);
1919

2020
String domain = resolver.resolve(Arrays.asList("agora.io", "sd-rtn.com"),
21-
RegionArea.CNRegionArea.getRegionDomainPrefixes().get(0)).block();
21+
DomainArea.CN.getRegionDomainPrefixes().get(0)).block();
2222

2323
logger.info("Domain: {}", domain);
2424
assertNotNull(domain);
2525
}
26-
}
26+
}

examples/cloudrecording/src/main/java/io/agora/rest/examples/cloudrecording/Main.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.agora.rest.examples.cloudrecording;
22

33
import io.agora.rest.core.BasicAuthCredential;
4-
import io.agora.rest.core.RegionArea;
4+
import io.agora.rest.core.DomainArea;
55
import io.agora.rest.examples.cloudrecording.scenario.IndividualRecordingScenario;
66
import io.agora.rest.examples.cloudrecording.scenario.MixRecordingScenario;
77
import io.agora.rest.examples.cloudrecording.scenario.WebRecordingScenario;
@@ -31,7 +31,7 @@ public class Main implements Callable<Integer> {
3131

3232
private String token;
3333

34-
private final RegionArea region = RegionArea.CNRegionArea;
34+
private final DomainArea region = DomainArea.CN;
3535

3636
private StartResourceReq.StorageConfig storageConfig;
3737

examples/cloudrecording/src/main/java/io/agora/rest/examples/cloudrecording/scenario/BaseScenario.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import io.agora.rest.core.AgoraConfig;
44
import io.agora.rest.core.Credential;
5-
import io.agora.rest.core.RegionArea;
5+
import io.agora.rest.core.DomainArea;
66
import io.agora.rest.services.cloudrecording.CloudRecordingClient;
77
import org.slf4j.Logger;
88
import org.slf4j.LoggerFactory;
@@ -11,7 +11,7 @@ public class BaseScenario {
1111

1212
private static final Logger logger = LoggerFactory.getLogger(BaseScenario.class);
1313

14-
protected final RegionArea region;
14+
protected final DomainArea domainArea;
1515

1616
protected final String appId;
1717

@@ -23,8 +23,8 @@ public class BaseScenario {
2323

2424
protected final CloudRecordingClient cloudRecordingClient;
2525

26-
public BaseScenario(RegionArea region, String appId, String cname, String uid, Credential credential) {
27-
this.region = region;
26+
public BaseScenario(DomainArea domainArea, String appId, String cname, String uid, Credential credential) {
27+
this.domainArea = domainArea;
2828
this.appId = appId;
2929
this.cname = cname;
3030
this.uid = uid;
@@ -33,7 +33,7 @@ public BaseScenario(RegionArea region, String appId, String cname, String uid, C
3333
AgoraConfig agoraConfig = AgoraConfig.builder()
3434
.appId(appId)
3535
.credential(credential)
36-
.regionArea(region)
36+
.domainArea(domainArea)
3737
.build();
3838

3939
logger.info("AgoraConfig: {}", agoraConfig);

examples/cloudrecording/src/main/java/io/agora/rest/examples/cloudrecording/scenario/IndividualRecordingScenario.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import io.agora.rest.AgoraException;
44
import io.agora.rest.core.Credential;
5-
import io.agora.rest.core.RegionArea;
5+
import io.agora.rest.core.DomainArea;
66
import io.agora.rest.services.cloudrecording.api.req.StartResourceReq;
77
import io.agora.rest.services.cloudrecording.api.req.UpdateResourceReq;
88
import io.agora.rest.services.cloudrecording.api.res.AcquireResourceRes;
@@ -22,8 +22,8 @@
2222
public class IndividualRecordingScenario extends BaseScenario {
2323
private static final Logger logger = LoggerFactory.getLogger(IndividualRecordingScenario.class);
2424

25-
public IndividualRecordingScenario(RegionArea region, String appId, String cname, String uid, Credential credential) {
26-
super(region, appId, cname, uid, credential);
25+
public IndividualRecordingScenario(DomainArea domainArea, String appId, String cname, String uid, Credential credential) {
26+
super(domainArea, appId, cname, uid, credential);
2727
}
2828

2929
public void runRecording(String token, StartResourceReq.StorageConfig storageConfig) {

0 commit comments

Comments
 (0)