Skip to content

Commit 2ba576a

Browse files
committed
suggested changes
1 parent feab3b8 commit 2ba576a

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

netty/src/main/java/io/grpc/netty/NettyClientTransport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ public void operationComplete(ChannelFuture future) throws Exception {
350350

351351
@Override
352352
public void shutdown(Status reason) {
353-
shutdown(reason, SimpleDisconnectError.UNKNOWN);
353+
shutdown(reason, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN);
354354
}
355355

356356
@Override
@@ -367,7 +367,7 @@ public void shutdown(Status reason, DisconnectError disconnectError) {
367367

368368
@Override
369369
public void shutdownNow(final Status reason) {
370-
shutdownNow(reason, SimpleDisconnectError.UNKNOWN);
370+
shutdownNow(reason, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN);
371371
}
372372

373373
@Override

okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -987,15 +987,7 @@ int getOverridenPort() {
987987

988988
@Override
989989
public void shutdown(Status reason) {
990-
synchronized (lock) {
991-
if (goAwayStatus != null) {
992-
return;
993-
}
994-
995-
goAwayStatus = reason;
996-
listener.transportShutdown(goAwayStatus, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN);
997-
stopIfNecessary();
998-
}
990+
shutdown(reason, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN);
999991
}
1000992

1001993
@Override
@@ -1013,12 +1005,12 @@ public void shutdown(Status reason, DisconnectError disconnectError) {
10131005

10141006
@Override
10151007
public void shutdownNow(Status reason) {
1016-
shutdownNow(reason, SimpleDisconnectError.UNKNOWN);
1008+
shutdownNow(reason, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN);
10171009
}
10181010

10191011
@Override
10201012
public void shutdownNow(Status reason, DisconnectError disconnectError) {
1021-
shutdown(reason);
1013+
shutdown(reason, disconnectError);
10221014
synchronized (lock) {
10231015
Iterator<Map.Entry<Integer, OkHttpClientStream>> it = streams.entrySet().iterator();
10241016
while (it.hasNext()) {

0 commit comments

Comments
 (0)