Skip to content

Commit 66fac05

Browse files
committed
fixe robolectricBinderTransportTest.clientReportsAuthzErrorToServer() test
1 parent 4754c1b commit 66fac05

File tree

2 files changed

+5
-18
lines changed

2 files changed

+5
-18
lines changed

binder/src/test/java/io/grpc/binder/internal/RobolectricBinderTransportTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ public void clientReportsAuthzErrorToServer() throws Exception {
388388
.build();
389389
runIfNotNull(client.start(mockClientTransportListener));
390390
verify(mockClientTransportListener, timeout(TIMEOUT_MS))
391-
.transportShutdown(statusCaptor.capture());
391+
.transportShutdown(statusCaptor.capture(), any(DisconnectError.class));
392392
assertThat(statusCaptor.getValue().getCode()).isEqualTo(Status.Code.PERMISSION_DENIED);
393393

394394
// Client doesn't tell the server in this case by design -- we don't even want to start it!

okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,15 +1836,11 @@ public void unreachableServer() throws Exception {
18361836
ManagedClientTransport.Listener listener = mock(ManagedClientTransport.Listener.class);
18371837
clientTransport.start(listener);
18381838
ArgumentCaptor<Status> statusCaptor = ArgumentCaptor.forClass(Status.class);
1839-
ArgumentCaptor<DisconnectError> errorCaptor = ArgumentCaptor.forClass(DisconnectError.class);
1840-
18411839
verify(listener, timeout(TIME_OUT_MS)).transportShutdown(statusCaptor.capture(),
1842-
errorCaptor.capture());
1840+
eq(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR)));
18431841
Status status = statusCaptor.getValue();
1844-
DisconnectError error = errorCaptor.getValue();
18451842
assertEquals(Status.UNAVAILABLE.getCode(), status.getCode());
18461843
assertTrue(status.getCause().toString(), status.getCause() instanceof IOException);
1847-
assertEquals(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR), error);
18481844

18491845
MockStreamListener streamListener = new MockStreamListener();
18501846
clientTransport.newStream(method, new Metadata(), CallOptions.DEFAULT, tracers)
@@ -1872,13 +1868,10 @@ public void customSocketFactory() throws Exception {
18721868
ManagedClientTransport.Listener listener = mock(ManagedClientTransport.Listener.class);
18731869
clientTransport.start(listener);
18741870
ArgumentCaptor<Status> statusCaptor = ArgumentCaptor.forClass(Status.class);
1875-
ArgumentCaptor<DisconnectError> errorCaptor = ArgumentCaptor.forClass(DisconnectError.class);
18761871
verify(listener, timeout(TIME_OUT_MS)).transportShutdown(statusCaptor.capture(),
1877-
errorCaptor.capture());
1872+
eq(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR)));
18781873
Status status = statusCaptor.getValue();
1879-
DisconnectError error = errorCaptor.getValue();
18801874
assertEquals(Status.UNAVAILABLE.getCode(), status.getCode());
1881-
assertEquals(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR), error);
18821875
assertSame(exception, status.getCause());
18831876
}
18841877

@@ -1968,11 +1961,9 @@ public void proxy_500() throws Exception {
19681961
assertEquals(-1, sock.getInputStream().read());
19691962

19701963
ArgumentCaptor<Status> statusCaptor = ArgumentCaptor.forClass(Status.class);
1971-
ArgumentCaptor<DisconnectError> errorCaptor = ArgumentCaptor.forClass(DisconnectError.class);
19721964
verify(transportListener, timeout(TIME_OUT_MS)).transportShutdown(statusCaptor.capture(),
1973-
errorCaptor.capture());
1965+
eq(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR)));
19741966
Status status = statusCaptor.getValue();
1975-
DisconnectError error = errorCaptor.getValue();
19761967
assertTrue("Status didn't contain error code: " + statusCaptor.getValue(),
19771968
status.getDescription().contains("500"));
19781969
assertTrue("Status didn't contain error description: " + statusCaptor.getValue(),
@@ -1981,7 +1972,6 @@ public void proxy_500() throws Exception {
19811972
status.getDescription().contains(errorText));
19821973
assertEquals("Not UNAVAILABLE: " + statusCaptor.getValue(),
19831974
Status.UNAVAILABLE.getCode(), status.getCode());
1984-
assertEquals(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR), error);
19851975
sock.close();
19861976
verify(transportListener, timeout(TIME_OUT_MS)).transportTerminated();
19871977
}
@@ -2009,16 +1999,13 @@ public void proxy_immediateServerClose() throws Exception {
20091999
sock.close();
20102000

20112001
ArgumentCaptor<Status> statusCaptor = ArgumentCaptor.forClass(Status.class);
2012-
ArgumentCaptor<DisconnectError> errorCaptor = ArgumentCaptor.forClass(DisconnectError.class);
20132002
verify(transportListener, timeout(TIME_OUT_MS)).transportShutdown(statusCaptor.capture(),
2014-
errorCaptor.capture());
2003+
eq(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR)));
20152004
Status status = statusCaptor.getValue();
2016-
DisconnectError error = errorCaptor.getValue();
20172005
assertTrue("Status didn't contain proxy: " + statusCaptor.getValue(),
20182006
status.getDescription().contains("proxy"));
20192007
assertEquals("Not UNAVAILABLE: " + statusCaptor.getValue(),
20202008
Status.UNAVAILABLE.getCode(), status.getCode());
2021-
assertEquals(new GoAwayDisconnectError(GrpcUtil.Http2Error.INTERNAL_ERROR), error);
20222009
verify(transportListener, timeout(TIME_OUT_MS)).transportTerminated();
20232010
}
20242011

0 commit comments

Comments
 (0)