-
Notifications
You must be signed in to change notification settings - Fork 83
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Right now we preserve the position, suze, url, and scroll offset of windows to restore when Agregore starts. Other browsers are also preserving the page history so that you can navigate back or forward if you need. We should save this info when the app closes
TODO:
- Use the webContents.navigationHistory API
- Have a const for
MAX_SAVED_HISTORY, default to 8 or 16 (or less?) - Modify [WindowManager.saveOpened][https://github.com/AgregoreWeb/agregore-browser/blob/master/src/window.js#L235]
- Get all the entries
- get the index
- If the entries length is greater than MAX_SAVED_HISTORY, remove the extra entries, reduce/increase the index to match.
- Save this as
history: {index, entries} - Modify openSaved
- Fetch out the history and pass it to
.open - Modify windowManager.open
- Call
window.web.navigationHistory.restorewith thehistoryobject if it was provided before callingwindow.load - Test it's working! The max history bit especially might be prone to bugs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Type
Projects
Status
Ready