Skip to content

ci: enable mypy and fail on mypy failures #53

@sneakers-the-rat

Description

@sneakers-the-rat

currently there is a linting step to run mypy:

- name: Run mypy
id: mypy
continue-on-error: true # Allow failure until codebase is fully typed
run: |
pdm run mypy .

however it fails (it doesn't even get to actually type checking because it's configured incorrectly) without marking the test run as failed because of the continue-on-error option: https://github.com/Aharoni-Lab/indeca/actions/runs/21266735522/job/61207662549?pr=52

mypy is great! and it would have prevented this bug because the type annotation doesn't match the default. it does take a bit of shifting time if the package isn't already strictly typed, so not trying to enable it now, but we should commit time to making the package pass mypy and then actually fail that action when mypy fails.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions