Merge pull request #282 from AhmedLSayed9/fix_dropdown_position_when_window_changes_horizontally

AhmedLSayed9 · web-flow · commit 75cd312d21db · 2024-05-26T00:28:08.000+03:00
Fix dropdown position when window changes horizontally
diff --git a/packages/dropdown_button2/CHANGELOG.md b/packages/dropdown_button2/CHANGELOG.md
@@ -1,3 +1,7 @@
+## UNRELEASED
+
+- Fix dropdown menu position when window changes horizontally, closes #243.
+
 ## 3.0.0-beta.15
 
 - Always call `onChanged` when tapping enabled item, closes #275.
diff --git a/packages/dropdown_button2/lib/src/dropdown_button2.dart b/packages/dropdown_button2/lib/src/dropdown_button2.dart
@@ -535,12 +535,7 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>>
     if (_rect.value == null) {
       return;
     }
-    final Rect newRect = _getRect();
-    //This avoid unnecessary rebuilds if _rect position hasn't changed
-    if (_rect.value!.top == newRect.top) {
-      return;
-    }
-    _rect.value = newRect;
+    _rect.value = _getRect();
   }
 
   TextStyle? get _textStyle =>

Original file line number	Diff line number	Diff line change
`@@ -535,12 +535,7 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>>`
`535`	`535`	`if (_rect.value == null) {`
`536`	`536`	`return;`
`537`	`537`	`}`
`538`		`- final Rect newRect = _getRect();`
`539`		`- //This avoid unnecessary rebuilds if _rect position hasn't changed`
`540`		`- if (_rect.value!.top == newRect.top) {`
`541`		`- return;`
`542`		`- }`
`543`		`- _rect.value = newRect;`
	`538`	`+ _rect.value = _getRect();`
`544`	`539`	`}`
`545`	`540`
`546`	`541`	`TextStyle? get _textStyle =>`