Rename, fix tests

Author: timokoessler

library/agent/Attack.ts

@@ -5,7 +5,7 @@ export type Kind =
   | "path_traversal"
   | "ssrf"
   | "code_injection"
-  | "blocked_outgoing_request";
+  | "blocked_outbound_connection";
 
 export function attackKindHumanName(kind: Kind) {
   switch (kind) {
@@ -21,7 +21,7 @@ export function attackKindHumanName(kind: Kind) {
       return "a server-side request forgery";
     case "code_injection":
       return "a JavaScript injection";
-    case "blocked_outgoing_request":
-      return "an outgoing request";
+    case "blocked_outbound_connection":
+      return "an outbound connection";
   }
 }

library/agent/api/ReportingAPIRateLimitedClientSide.test.ts

@@ -234,6 +234,7 @@ t.test("it does not blow memory", async () => {
       heartbeatIntervalInMS: 10 * 60 * 1000,
       blockedUserIds: [],
       allowedIPAddresses: [],
+      blockNewOutgoingRequests: false,
     });
   }
 

library/agent/api/ReportingAPIRateLimitedServerSide.test.ts

@@ -49,6 +49,7 @@ t.test("it stops sending requests if rate limited", async (t) => {
     configUpdatedAt: 0,
     blockedUserIds: [],
     allowedIPAddresses: [],
+    blockNewOutgoingRequests: false,
   });
   t.match(api.getEvents(), [{ type: "started" }]);
 

library/agent/api/ReportingAPIThatValidatesToken.test.ts

@@ -47,6 +47,7 @@ t.test("it ignores valid tokens", async () => {
     heartbeatIntervalInMS: 10 * 60 * 1000,
     blockedUserIds: [],
     allowedIPAddresses: [],
+    blockNewOutgoingRequests: false,
   });
   t.same(api.getEvents(), [event]);
 
@@ -57,6 +58,7 @@ t.test("it ignores valid tokens", async () => {
     heartbeatIntervalInMS: 10 * 60 * 1000,
     blockedUserIds: [],
     allowedIPAddresses: [],
+    blockNewOutgoingRequests: false,
   });
   t.same(api.getEvents(), [event, event]);
 });

library/agent/hooks/onInspectionInterceptorResult.ts

@@ -40,7 +40,11 @@ export function onInspectionInterceptorResult(
     context.remoteAddress &&
     agent.getConfig().isBypassedIP(context.remoteAddress);
 
-  if (result && !isBypassedIP && result.kind === "blocked_outgoing_request") {
+  if (
+    result &&
+    !isBypassedIP &&
+    result.kind === "blocked_outbound_connection"
+  ) {
     throw cleanError(
       new Error(
         `Zen has blocked ${attackKindHumanName(result.kind)}: ${result.operation}(...) to ${escapeHTML(result.payload as string)}`

library/sinks/Fetch.test.ts

@@ -441,7 +441,7 @@ t.test(
     if (blockedError1 instanceof Error) {
       t.same(
         blockedError1.message,
-        "Zen has blocked an outgoing request: fetch(...) to https://aikido.dev/block"
+        "Zen has blocked an outbound connection: fetch(...) to https://aikido.dev/block"
       );
     }
 
@@ -459,7 +459,7 @@ t.test(
     if (blockedError2 instanceof Error) {
       t.same(
         blockedError2.message,
-        "Zen has blocked an outgoing request: fetch(...) to https://example.com/"
+        "Zen has blocked an outbound connection: fetch(...) to https://example.com/"
       );
     }
 

library/sinks/Fetch.ts

@@ -25,7 +25,7 @@ export class Fetch implements Wrapper {
 
       return {
         operation: "fetch",
-        kind: "blocked_outgoing_request",
+        kind: "blocked_outbound_connection",
         source: "url",
         pathsToPayload: [],
         metadata: {},

library/sinks/HTTPRequest.test.ts

@@ -313,7 +313,7 @@ t.test("it works", (t) => {
   if (blockedError1 instanceof Error) {
     t.same(
       blockedError1.message,
-      "Zen has blocked an outgoing request: https.request(...) to https://aikido.dev/block"
+      "Zen has blocked an outbound connection: https.request(...) to https://aikido.dev/block"
     );
   }
 
@@ -331,7 +331,7 @@ t.test("it works", (t) => {
   if (blockedError2 instanceof Error) {
     t.same(
       blockedError2.message,
-      "Zen has blocked an outgoing request: https.request(...) to https://example.com/"
+      "Zen has blocked an outbound connection: https.request(...) to https://example.com/"
     );
   }
 

library/sinks/HTTPRequest.ts

@@ -28,7 +28,7 @@ export class HTTPRequest implements Wrapper {
 
       return {
         operation: `${module}.request`,
-        kind: "blocked_outgoing_request",
+        kind: "blocked_outbound_connection",
         source: "url",
         pathsToPayload: [],
         metadata: {},

library/sinks/Undici.tests.ts

@@ -432,7 +432,7 @@ export function createUndiciTests(undiciPkgName: string, port: number) {
       if (blockedError1 instanceof Error) {
         t.same(
           blockedError1.message,
-          "Zen has blocked an outgoing request: undici.request(...) to aikido.dev"
+          "Zen has blocked an outbound connection: undici.request(...) to aikido.dev"
         );
       }
 
@@ -457,7 +457,7 @@ export function createUndiciTests(undiciPkgName: string, port: number) {
       if (blockedError2 instanceof Error) {
         t.same(
           blockedError2.message,
-          "Zen has blocked an outgoing request: undici.request(...) to example.com"
+          "Zen has blocked an outbound connection: undici.request(...) to example.com"
         );
       }