Ignore full ai generated sql queries

Author: timokoessler

library/vulnerabilities/sql-injection/checkContextForSqlInjection.ts

@@ -28,7 +28,7 @@ export function checkContextForSqlInjection({
     }
 
     for (const str of userInput) {
-      if (detectSQLInjection(sql, str, dialect)) {
+      if (detectSQLInjection(sql, str, dialect, source)) {
         return {
           operation: operation,
           kind: "sql_injection",

library/vulnerabilities/sql-injection/detectSQLInjection.test.ts

@@ -259,6 +259,59 @@ t.test("It does not match GROUP keyword", async () => {
   isNotSqlInjection(query, "ASC");
 });
 
+t.test(
+  "it ignores full SQL queries from the source aiToolParams",
+  async (t) => {
+    const generic = new SQLDialectGeneric();
+    t.same(
+      detectSQLInjection(
+        "SELECT * FROM 'test';",
+        "SELECT * FROM 'test';",
+        generic,
+        "body"
+      ),
+      true
+    );
+    t.same(
+      detectSQLInjection(
+        "SELECT * FROM 'test';",
+        "'test';",
+        generic,
+        "aiToolParams"
+      ),
+      true
+    );
+    t.same(
+      detectSQLInjection(
+        "SELECT * FROM 'test'; DELETE FROM 'test'; -- ';",
+        "test'; DELETE FROM 'test'; -- ';",
+        generic,
+        "aiToolParams"
+      ),
+      true
+    );
+
+    t.same(
+      detectSQLInjection(
+        "SELECT * FROM 'test';",
+        "SELECT * FROM 'test';",
+        generic,
+        "aiToolParams"
+      ),
+      false
+    );
+    t.same(
+      detectSQLInjection(
+        "DELETE FROM 'test';",
+        "DELETE FROM 'test';",
+        generic,
+        "aiToolParams"
+      ),
+      false
+    );
+  }
+);
+
 const files = [
   // Taken from https://github.com/payloadbox/sql-injection-payload-list/tree/master
   join(__dirname, "payloads", "Auth_Bypass.txt"),

library/vulnerabilities/sql-injection/detectSQLInjection.ts

@@ -2,16 +2,29 @@ import { SQLDialect } from "./dialects/SQLDialect";
 import { shouldReturnEarly } from "./shouldReturnEarly";
 // eslint-disable-next-line camelcase
 import { wasm_detect_sql_injection } from "../../internals/zen_internals";
+import type { Source } from "../../agent/Source";
 
 export function detectSQLInjection(
   query: string,
   userInput: string,
-  dialect: SQLDialect
+  dialect: SQLDialect,
+  source: Source | undefined = undefined
 ) {
   if (shouldReturnEarly(query, userInput)) {
     return false;
   }
 
+  // Ignore full SQL queries from the source aiToolParams
+  // This is to prevent false positives when the AI tool is generating SQL queries
+  // It was already checked in shouldReturnEarly that the query includes user input
+  if (
+    source &&
+    source === "aiToolParams" &&
+    query.length === userInput.length
+  ) {
+    return false;
+  }
+
   return wasm_detect_sql_injection(
     query.toLowerCase(),
     userInput.toLowerCase(),